Skip to content

Conversation

@KolbyML
Copy link
Contributor

@KolbyML KolbyML commented Jun 5, 2022

No description provided.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 210cd59

@Zeyu-Li
Copy link

Zeyu-Li commented Jun 5, 2022

lgtm

Copy link
Contributor

@LarryRuane LarryRuane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 210cd59

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 5, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #25110 (tidy: use modernize-use-raw-string-literal by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Contributor

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crACK 210cd59

@brunoerg
Copy link
Contributor

brunoerg commented Jun 5, 2022

You could fix all typos in this PR.

See:

src/kernel/context.h:15: libary ==> library
src/net.cpp:1106: Desig ==> Design
src/net.cpp:1107: Desig ==> Design
src/net.cpp:1108: Desig ==> Design
src/net.cpp:1109: Desig ==> Design
src/net.cpp:1110: Desig ==> Design
src/net.cpp:1111: Desig ==> Design
src/net.cpp:1112: Desig ==> Design
src/net.cpp:1113: Desig ==> Design
src/net.cpp:1114: Desig ==> Design
src/net.cpp:1115: Desig ==> Design
src/net.cpp:1116: Desig ==> Design
src/net.cpp:1117: Desig ==> Design
src/util/designator.h:16: Desig ==> Design
src/util/designator.h:18: Desig ==> Design

@hebasto
Copy link
Member

hebasto commented Jun 5, 2022

You could fix all typos in this PR.

See:

src/kernel/context.h:15: libary ==> library
src/net.cpp:1106: Desig ==> Design
src/net.cpp:1107: Desig ==> Design
src/net.cpp:1108: Desig ==> Design
src/net.cpp:1109: Desig ==> Design
src/net.cpp:1110: Desig ==> Design
src/net.cpp:1111: Desig ==> Design
src/net.cpp:1112: Desig ==> Design
src/net.cpp:1113: Desig ==> Design
src/net.cpp:1114: Desig ==> Design
src/net.cpp:1115: Desig ==> Design
src/net.cpp:1116: Desig ==> Design
src/net.cpp:1117: Desig ==> Design
src/util/designator.h:16: Desig ==> Design
src/util/designator.h:18: Desig ==> Design

I think Desig is a correct macro's name :)

@brunoerg
Copy link
Contributor

brunoerg commented Jun 5, 2022

I think Desig is a correct macro's name :)

nice, we could add it to spelling.ignore-words.txt

@maflcko maflcko merged commit e82d806 into bitcoin:master Jun 6, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 6, 2022
210cd59 doc: Fix typo in importdescriptors (Kolby Moroz Liebl)

Pull request description:

ACKs for top commit:
  1440000bytes:
    ACK bitcoin@210cd59
  LarryRuane:
    ACK 210cd59
  brunoerg:
    crACK 210cd59

Tree-SHA512: 39ff9777b05abc1a68c8c3e646e00b0672838696c567c582d0492baa753863231447fd8439bd41cd8a8b8ba752299b032e839c8862c02faa2bdc207a9a7a8540
@bitcoin bitcoin locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants