Move minRelayTxFee to policy/settings #25254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix includes using iwyu
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jun 1, 2022
ariard
approved these changes
Jun 6, 2022
| } // namespace Consensus | ||
|
|
||
| /** Default for -minrelaytxfee, minimum relay fee for transactions */ | ||
| static const unsigned int DEFAULT_MIN_RELAY_TX_FEE = 1000; |
There was a problem hiding this comment.
What do you think to move too the following default values validation.h from in policy.h ?
DEFAULT_ANCESTOR_LIMITDEFAULT_ANCESTOR_SIZE_LIMITDEFAULT_DESCENDANT_LIMITDEFAULT_DESCENDANT_SIZE_LIMITDEFAULT_MEMPOOL_EXPIRY
Member
Author
There was a problem hiding this comment.
Happy to review a follow-up, if someone creates one.
ryanofsky
approved these changes
Jun 6, 2022
Contributor
There was a problem hiding this comment.
Code review ACK fa4068b. Make sense to move the global variable to policy/settings and the default constant to policy/policy. Ariard points out other constants that could be moved, which seems fine, but it seems like moving the global variable to be with other related global variables is more significant.
I think this variable was just forgotten in 4a75c9d from #15638 which moved other variables because it wasn't used by wallet code
This was referenced Jun 7, 2022
ghost
mentioned this pull request
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 8, 2022
fa4068b Move minRelayTxFee to policy/settings (MacroFake) Pull request description: Seems a bit confusing to put policy stuff into validation, so fix that. Also fix includes via `iwyu`. ACKs for top commit: ariard: ACK fa4068b, the includes move compiles well locally. ryanofsky: Code review ACK fa4068b. Make sense to move the global variable to policy/settings and the default constant to policy/policy. Ariard points out other constants that could be moved, which seems fine, but it seems like moving the global variable to be with other related global variables is more significant. Tree-SHA512: adf9619002610d1877f3aef0a9e6115fc4c2ad64135a3e5100824c650b560c47f47ac28894c6214a50a7888355252a9f6f7cec98c23a771a1964160ef1ca77de
laanwj
added a commit
to bitcoin-core/gui
that referenced
this pull request
Jun 20, 2022
0d8e68d refactor: move DEFAULT_*_LIMIT assertions from validation to policy (fanquake) 9c94f3b refactor: move EXTRA_DESCENDANT_TX_SIZE_LIMIT to policy/policy.h (fanquake) 39c6036 refactor: use braced initialization in policy/policy.h (fanquake) 01ccfbe scripted-diff: use static constexpr in policy/policy.h (fanquake) 62d56bb refactor: Move DEFAULT_DESCENDANT_SIZE_LIMIT to policy/policy.h (fanquake) a34aa4c refactor: Move DEFAULT_DESCENDANT_LIMIT to policy/policy.h (fanquake) 05fc5fd refactor: Move DEFAULT_ANCESTOR_SIZE_LIMIT to policy/policy.h (fanquake) da8d304 refactor: Move DEFAULT_ANCESTOR_LIMIT to policy/policy.h (CAnon) Pull request description: Picks up #25295. Which was a follow up to [a comment in #25254](bitcoin/bitcoin#25254 (comment)). Moves policy constants from validation.h to policy.h. ACKs for top commit: laanwj: Code review ACK 0d8e68d w0xlt: reACK bitcoin/bitcoin@0d8e68d darosior: ACK 0d8e68d Tree-SHA512: 79900b09dc3a8020b5053ec734f462cb6e8184ed2b76e9d8afae7fe5331bbc906daaa42c0f622782797d971aaf5698aa0155511ec1d15582cc7675c271664a8d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems a bit confusing to put policy stuff into validation, so fix that.
Also fix includes via
iwyu.