test: add coverage for non-hex value to -minimumchainwork #25253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapsk
approved these changes
May 30, 2022
Contributor
kristapsk
left a comment
kristapsk
left a comment
There was a problem hiding this comment.
ACK 49fe179f00f2ffa1eb96b7737b6b07c92dc5e865
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
brunoerg
force-pushed
the
2022-05-minimumchainwork-nonhex
branch
from
49fe179 to
ebfc308
Compare
Contributor
Author
|
Rebased |
kristapsk
approved these changes
May 31, 2022
Member
|
Code review ACK ebfc308 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 31, 2022
…chainwork ebfc308 test: add coverage for non-hex value to -minimumchainwork (brunoerg) Pull request description: This PR adds test coverage for the following init error: https://github.com/bitcoin/bitcoin/blob/b9ef5a10e2fa4609d048db57b99463305455ebe4/src/init.cpp#L917-L919 Passing a non-hex value to -minimumchainwork should throw an initial error. ACKs for top commit: laanwj: Code review ACK ebfc308 kristapsk: re-ACK ebfc308 Tree-SHA512: c665903757ae3b8b2480df97bb888e60ba4387b009fcb8031041822e87a155a0e4950ebe79873c1034f0826504521d82b1fdfdb5e8378b227d14ca545b8d4e11
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for the following init error:
bitcoin/src/init.cpp
Lines 917 to 919 in b9ef5a1
Passing a non-hex value to -minimumchainwork should throw an initial error.