Skip to content

Conversation

@laanwj
Copy link
Member

@laanwj laanwj commented Apr 14, 2013

This allows the bool* type to be passed between threads. Should solve issue #2402.

This allows the bool* type to be passed between threads.  Should solve issue bitcoin#2402.
@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e83a90f127060487b7a6717a740a59db244b4e53 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@Diapolo
Copy link

Diapolo commented Apr 14, 2013

Did my hint draw your attention on this? Nice finde anyway :).

@laanwj
Copy link
Member Author

laanwj commented Apr 14, 2013

@Diapolo, yes, and that it was not the diskspace warning but a leveldb error (likely in the network thread while accepting a block). It's still strange that it sometimes worked (like for askFee) and sometimes did not, but this should solve it for good.

laanwj added a commit that referenced this pull request Apr 18, 2013
@laanwj laanwj merged commit 72782f3 into bitcoin:master Apr 18, 2013
namecoin-qt referenced this pull request in namecoin-qt/namecoin-qt May 31, 2013
qt: register metatype for bool*

This allows the bool* type to be passed between threads.  Should solve issue #2402.
davispuh referenced this pull request in davispuh/namecoin Feb 18, 2014
qt: register metatype for bool*

This allows the bool* type to be passed between threads.  Should solve issue #2402.
laudney pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request Mar 19, 2014
@laanwj laanwj deleted the 2013_04_metatypebool branch April 9, 2014 14:19
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants