rpc: Put undocumented JSON failure mode behind a runtime flag #25161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-jr
suggested changes
May 17, 2022
luke-jr
reviewed
May 18, 2022
luke-jr
suggested changes
May 18, 2022
luke-jr
reviewed
May 18, 2022
Member
|
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits |
Contributor
Author
|
It says I can't squash because "A merge commit cannot exist among those commits". Would anyone know how to fix that? |
Member
|
See #25165 |
Contributor
Author
|
When I do So the current situation I'm in is that the changes are committed on my master branch. So I did |
maflcko
reviewed
May 18, 2022
Member
|
I've reworked #25165 . Hopefully it should be clearer now? |
rpc: Put undocumented JSON failure mode behind a runtime flag
luke-jr
approved these changes
May 18, 2022
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
May 21, 2022
rpc: Put undocumented JSON failure mode behind a runtime flag Github-Pull: bitcoin#25161 Rebased-From: b953ea6
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 28, 2022
… runtime flag b953ea6 rpc: Put undocumented JSON failure mode behind a runtime flag (Suhail Saqan) Pull request description: Fixes bitcoin#24695 (Put undocumented JSON failure mode behind a runtime flag) ACKs for top commit: luke-jr: utACK b953ea6 vincenzopalazzo: ACK bitcoin@b953ea6 Tree-SHA512: 2005ee1b1f3b637918390b2ecd4166f2fd8c86e3c59fba3da8a0cbd5b1dffd03190c92f6dca3c489ecce4276eaf3108b2edcf9cd6224b713adb52f5bb848163b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24695 (Put undocumented JSON failure mode behind a runtime flag)