doc: Fix incorrect sendmany RPC doc #25093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Rendered diff: diff --git a/sendmany b/sendmany
index 67f8189..6698a7d 100644
--- a/sendmany
+++ b/sendmany
@@ -1,10 +1,10 @@
-sendmany "" {"address":amount,...} ( minconf "comment" ["address",...] replaceable conf_target "estimate_mode" fee_rate verbose )
+sendmany ( "" ) {"address":amount,...} ( minconf "comment" ["address",...] replaceable conf_target "estimate_mode" fee_rate verbose )
Send multiple times. Amounts are double-precision floating point numbers.
Requires wallet passphrase to be set with walletpassphrase call if wallet is encrypted.
Arguments:
-1. dummy (string, required) Must be set to "" for backwards compatibility.
+1. dummy (string, optional, default="\"\"") Must be set to "" for backwards compatibility.
2. amounts (json object, required) The addresses and amounts
{
"address": amount, (numeric or string, required) The bitcoin address is the key, the numeric amount (can be string) in BTC is the value |
maflcko
force-pushed
the
2205-doc-rpc-opt-
branch
from
fa078a6 to
fa0b1ca
Compare
maflcko
changed the title
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Closed
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
May 21, 2022
Github-Pull: bitcoin#25093 Rebased-From: fa0b1cac9daca70bc7a95d1d34604d28979cfd08 [partial]
This was referenced Sep 8, 2022
maflcko
force-pushed
the
2205-doc-rpc-opt-
branch
from
fa0b1ca to
aed6ce8
Compare
This was referenced Dec 12, 2022
This was referenced Dec 22, 2022
maflcko
force-pushed
the
2205-doc-rpc-opt-
branch
from
aed6ce8 to
711fb0c
Compare
maflcko
force-pushed
the
2205-doc-rpc-opt-
branch
2 times, most recently
from
fa0a6a3 to
fa6f782
Compare
maflcko
changed the title
DrahtBot
changed the title
This enables the type check and fixes the wrong docs. Otherwise the enabled check would lead to test errors, such as: > "wallet_labels.py", line 96, in run_test > node.sendmany( > > test_framework.authproxy.JSONRPCException: > JSON value of type null is not of expected type string (-3)
maflcko
force-pushed
the
2205-doc-rpc-opt-
branch
from
fa6f782 to
fa95f20
Compare
Member
Author
|
Completely reworked this, since the check has been merged, to only fixup the RPC doc |
fanquake
approved these changes
Jan 17, 2023
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 17, 2023
fa95f20 doc: Fix incorrect sendmany RPC doc (MarcoFalke) fa96f93 test: Add test for missing and omitted required arg (MarcoFalke) Pull request description: This enables the skipped type check for `sendmany` and fixes the resulting error. Also, there is an unrelated test-only commit. ACKs for top commit: fanquake: ACK fa95f20 Tree-SHA512: 6f9992786472d3927485a34e918db76824cfb60fa96f42cc9c3cdba7074fe08c657bd77cb3e748432161a290f2dcf90bb0ece279904bd274c529119e65fa0959
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the skipped type check for
sendmanyand fixes the resulting error.Also, there is an unrelated test-only commit.