Wrap boost::replace_all #25068
Merged
Wrap boost::replace_all #25068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Concept ACK. |
Member
|
Concept ACK, good idea to wrap or pimpl as much of boost as possible, to avoid huge amount of headers code being compiled for everything. |
Contributor
|
Concept ACK |
|
Concept ACK There is one more instance of boost:replace_all in https://github.com/bitcoin/bitcoin/blob/fa7734d7e7e52ec9557c9508d6be164025ff90d7/src/util/system.cpp#L1255 |
|
ACK fa2deae |
Contributor
|
Approach ACK |
Contributor
|
ACK fa2deae |
Contributor
|
ACK fa2deae. Next step, replace with custom implementation to get rid of another boost header? nit: string.cpp shows |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 9, 2022
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 19, 2023
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jan 19, 2023
backport: merge bitcoin#18289, bitcoin#19090, bitcoin#22859, bitcoin#18758, bitcoin#21016, bitcoin#22953, bitcoin#25027, bitcoin#20461, bitcoin#25025, bitcoin#25057, bitcoin#25068 (deboostification)
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 6, 2023
Summary: The included header is thousand lines of template code (not counting the recursive includes) for basically one function. This is a backport of [[bitcoin/bitcoin#25068 | core#25068]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D13240
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included header is thousand lines of template code (not counting the recursive includes) for basically one function.