test: previous releases: add v23.0 #25063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
prusnak
suggested changes
May 4, 2022
test/get_previous_releases.py
Outdated
Contributor
There was a problem hiding this comment.
The comparison float(tag[1:]) < 23 looks ugly ... doesn't it break when tag is e.g. "v0.21.0"?
I think the simple tag < "v23" or tag[1:] < "23" does the trick, no?
Also this is Python so we can use platform in ...
Suggested change
| if float(tag[1:]) < 23 and (platform == "x86_64-apple-darwin" or platform == "aarch64-apple-darwin"): | |
| if tag < "v23" and platform in ["x86_64-apple-darwin", "aarch64-apple-darwin"]: |
Starting from v23.0 there is a separate macOS release for x86_64 and aarch64. Co-authored-by: Pavol Rusnak <[email protected]>
Sjors
force-pushed
the
2022/05/add_previous_release
branch
from
b395bb6 to
dba1231
Compare
prusnak
approved these changes
May 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the same pattern as d8b705f (v22.0) and 8a57a06 (v0.21.0).
Starting from v23.0 there is a separate macOS release for x86_64 and aarch64.