tidy: add readability-redundant-declaration #25047
Conversation
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
Review-only ACK c2b2958
Finds redundant variable and function declarations. Such redundant declarations can be removed without changing program behavior. They can for instance be unintentional left overs from previous refactorings when code has been moved around. Having redundant declarations could in worst case mean that there are typos in the code that cause bugs.
Normally the code can be automatically fixed, clang-tidy can remove the second declaration. However there are 2 cases when you need to fix the code manually:
- When the declarations are in different header files;
- When multiple variables are declared together.
|
Seems low benefit (would be hard to imagine this catches a real bug), but also low cost (would be hard to imagine this is hit more than once a year on a pull request), so it seems fine to merge. |
c2b2958 tidy: add readability-redundant-declaration (fanquake) Pull request description: ACKs for top commit: vincenzopalazzo: ACK bitcoin@c2b2958 jonatack: Review-only ACK c2b2958 Tree-SHA512: 992dd81f9d0c511efcd8d9d1a8c05fc1401b854272f28f7f31ca0922164ddd7d7c01bfcf5ca268472b5d68969137110f5c0844a52938d294750584e1a948a874
c2b2958 tidy: add readability-redundant-declaration (fanquake) Pull request description: ACKs for top commit: vincenzopalazzo: ACK bitcoin@c2b2958 jonatack: Review-only ACK c2b2958 Tree-SHA512: 992dd81f9d0c511efcd8d9d1a8c05fc1401b854272f28f7f31ca0922164ddd7d7c01bfcf5ca268472b5d68969137110f5c0844a52938d294750584e1a948a874
5 participants
No description provided.