test: add coverage for invalid requests for blockfilterheaders (REST)
#25045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoerg
changed the title
blockfilterheadersblockfilterheaders (REST)
jacobpfickes
reviewed
May 2, 2022
Contributor
jacobpfickes
left a comment
jacobpfickes
left a comment
There was a problem hiding this comment.
ACK f11b8216fe6ec79b23c603ac185095222d0e9ff5
Pulled and verified additions. Great work
jonatack
reviewed
May 3, 2022
Member
There was a problem hiding this comment.
Light ACK f11b8216fe6ec79b23c603ac185095222d0e9ff5, this builds on and is similar to predecessor commit bd52684
Should the logging be updated? e.g.
--- a/test/functional/interface_rest.py
+++ b/test/functional/interface_rest.py
@@ -219,7 +219,7 @@ class RESTTest (BitcoinTestFramework):
self.generate(self.nodes[0], 1) # generate block to not affect upcoming tests
- self.log.info("Test the /block, /blockhashbyheight and /headers URIs")
+ self.log.info("Test the /block, /blockhashbyheight, /headers, and /blockfilterheaders URIs")
bb_hash = self.nodes[0].getbestblockhash()
Contributor
Author
@jonatack, yes! Not only because of this PR, but it should be updated anyway because in that range of code there are some tests involving |
brunoerg
force-pushed
the
2022-04-invalid-blockfilterheaders
branch
from
c817d89 to
d1bfe5e
Compare
Member
|
ACK d1bfe5e |
Contributor
|
Post-merged ACK d1bfe5e |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 4, 2022
…ckfilterheaders` (REST) d1bfe5e test: add coverage for invalid requests for `blockfilterheaders` (brunoerg) Pull request description: This PR adds test coverage for invalid requests (`Invalid hash` and `Unknown filtertype`) for `/blockfilterheaders` in REST functional test. ACKs for top commit: jonatack: ACK d1bfe5e vincenzopalazzo: ACK bitcoin@d1bfe5e Tree-SHA512: 9ab7efe7131296577c60642f95921799cf1dbae9c2aaea6752d2ac9f35a1bcc72b9d742a146c314f82fe1848190a80c88836ab78fc28773ed12e97fa327828e7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for invalid requests (
Invalid hashandUnknown filtertype) for/blockfilterheadersin REST functional test.