normalize PSBT entry instead of external signer master fingerprint #25032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but check both upper/lower hex representation
This was referenced Apr 29, 2022
Contributor
Author
|
closing this in favor of #25019 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some external signers scripts may provide master fingerprint in uppercase format. In that case core will fail with
Signer fingerprint 00000000 does not match any of the inputsas it only works with lowercase format. Even if the fingerprints match, yet one is lowercase the other uppercase.Core can instead normalize fingerprint from PSBT and check both upper/lower case hex representation
Very similar to #25019 but no changing of fingerprint from external signer.