Skip to content

Conversation

@Diapolo
Copy link

@Diapolo Diapolo commented Apr 9, 2013

  • don't display "Bitcoin - " when no title was supplied but just "Bitcoin"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the duplication here...

What you are really doing is:

    /* Override title based on style */
    QString msgType;
    switch(style) {
        case MSG_ERROR: msgType="Error"; break;
        case MSG_WARNING: msgType="Warning"; break;
        case MSG_INFORMATION: msgType="Information"; break;
        default: msgType = title; // Use supplied title
    }
    if(!msgType.isEmpty())
    {
        strTitle += " - " + msgType;
    }

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, will change that :).

@Diapolo
Copy link
Author

Diapolo commented Apr 11, 2013

Updated to reflect @laanwj suggestions.

- don't display "Bitcoin - " when no title was supplied but just "Bitcoin"
@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/8d643c90a6e0f1b69f23738701cb7a090870669c for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@sipa
Copy link
Member

sipa commented Apr 12, 2013

ACK

laanwj added a commit that referenced this pull request Apr 13, 2013
Bitcoin-Qt: remove " - " on empty title in BitcoinGUI::message()
@laanwj laanwj merged commit ac89a1e into bitcoin:master Apr 13, 2013
laudney pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request Mar 19, 2014
Bitcoin-Qt: remove " - " on empty title in BitcoinGUI::message()
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants