contrib: Remove suspicious hosts list from makeseeds #24862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have some qualms with maintaining a suspicious hosts list as part as the repository. But also, it's stale and irrelevant. I've checked the entire list and none of them is connectable. Only one still appars in `nodes_main.txt` but with low uptime and an old subversion string so it wouldn't be picked in the first place.
11 tasks
Contributor
|
Concept ACK this seems like not very effective cat and mouse stuff. I also looked through the code and the proposed change looks comprehensive / complete. |
ghost
approved these changes
Apr 15, 2022
Member
|
ACK |
Contributor
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 5, 2022
Summary: Backport of [[bitcoin/bitcoin#24862 | core#24862]] and skipping [[bitcoin/bitcoin#17823 | core#17823]] The list is outdated and unmaintained. Additional rationale can be found in the original pr. Test Plan: Run makeseeds according to readme. Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D12143
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some qualms about maintaining a suspicious hosts list as part as the repository*. But also, it's stale and irrelevant. I've checked the entire list and none of them is connectable. Only one still appars in
nodes_main.txtbut with low uptime and an old subversion string so it wouldn't be picked in the first place. This change removes the list and the functionality to use it.nodes_main.txtref: #17020 (comment)
* besides the commit noise, potential legal issues around accountability and liability that would come with maintaining such a blocklist actively, I don't think we should expose the project to