-
Notifications
You must be signed in to change notification settings - Fork 38.6k
test: port 'lint-shell.sh' to python #24840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: port 'lint-shell.sh' to python #24840
Conversation
maflcko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
|
I think I need a little help squashing my commits in this pull request. Because in commit Here's what I'm doing:
About halfway thru I get a bunch of merge conflicts. Any help is appreciated. Thanks. |
|
untested: Maybe we should mention those steps as well in the doc? |
We could. Though only as a last-ditch option if you've ended up with a mess of merge commits. |
d8afdaf to
ccf67cf
Compare
|
I believe I have finished squashing the commits. I will keep learning and practice |
a6f34e1 to
fcb895f
Compare
fcb895f to
2b35abe
Compare
2b35abe to
7b29dbd
Compare
7b29dbd to
bd6ceb4
Compare


Converts
test/lint/lint-shell.shto Python and updates the docs accordingly. In order for the linter to run, it requiresgitand theshellchecklinter to be installed on the system. The script will fail gracefully with a help message ifshellcheckis not installed.