doc: Use DecodeTxDoc helper #24721
Merged
doc: Use DecodeTxDoc helper #24721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
Member
Author
|
Rendered diff is move-only: diff --git a/getrawtransaction b/getrawtransaction
index e1a266d..ae73e6b 100644
--- a/getrawtransaction
+++ b/getrawtransaction
@@ -23,6 +23,10 @@ Result (if verbose is not set or set to false):
Result (if verbose is set to true):
{ (json object)
"in_active_chain" : true|false, (boolean, optional) Whether specified block is in the active chain or not (only present with explicit "blockhash" argument)
+ "blockhash" : "hex", (string, optional) the block hash
+ "confirmations" : n, (numeric, optional) The confirmations
+ "blocktime" : xxx, (numeric, optional) The block time expressed in UNIX epoch time
+ "time" : n, (numeric, optional) Same as "blocktime"
"hex" : "hex", (string) The serialized, hex-encoded data for 'txid'
"txid" : "hex", (string) The transaction id (same as provided)
"hash" : "hex", (string) The transaction hash (differs from txid for witness transactions)
@@ -61,11 +65,7 @@ Result (if verbose is set to true):
}
},
...
- ],
- "blockhash" : "hex", (string, optional) the block hash
- "confirmations" : n, (numeric, optional) The confirmations
- "blocktime" : xxx, (numeric, optional) The block time expressed in UNIX epoch time
- "time" : n (numeric, optional) Same as "blocktime"
+ ]
}
Examples: |
fanquake
approved these changes
Mar 31, 2022
shaavan
approved these changes
Mar 31, 2022
Contributor
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
ACK fa58427
- This newly introduced helper function, DecodeTxDoc, helps display all the text in the RPC help message for getting a transaction and decoderawtransaction.
- Since almost all the text in both of these functions help message is the same, this function helps remove the redundant lines of code while ensuring consistency in the displayed message for both these RPC commands.
- I compiled the PR successfully, and I was able to verify that the displayed RPC help message is unchanged.
Screenshot:
Contributor
|
I want to bring a point to notice. While compiling the PR, I got a bunch of repeated (same) warnings, whose screenshot I am adding here.
Since this doesn't seem relevant to this PR, I am adding it as a separate comment. I am running bitcoin core on Ubuntu 20.04. I am not sure if this is a genuine issue or my system's fault. |
Member
Author
|
See #24714 (comment) for the gcc-8 and gcc-9 bug |
Member
|
Post-merge ACK |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.