Skip to content

[23.x] macOS / build backports #24593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 6 commits into from
Mar 17, 2022
Merged

[23.x] macOS / build backports #24593

laanwj merged 6 commits into from
Mar 17, 2022

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Mar 16, 2022 •
edited
Loading

achow101 and others added 5 commits March 16, 2022 20:47
@achow101 @fanquake
Update signapple for platform identifier fix
de52879 
Github-Pull: bitcoin#24573
Rebased-From: 3c74f77
@hebasto @fanquake
guix: Use $HOST instead of generic osx{64} for macOS artifacts
7f6420c 
Github-Pull: bitcoin#24549
Rebased-From: 933a430
@hebasto @fanquake
guix: Drop "-signed" suffix for signed macOS .dmg files
2e7cde8 
This change makes naming of the signed artifacts consistent across
different OSes, including Windows.

Github-Pull: bitcoin#24549
Rebased-From: 4b4b04a
@hebasto @fanquake
guix: Use "win64" for Windows artifacts consistently
dd2c7f7 
Github-Pull: bitcoin#24549
Rebased-From: 53dd616
@hebasto @fanquake
doc: Drop a note about Intel-based Macs
f541a25 
Github-Pull: bitcoin#24588
Rebased-From: e359ba6
@fanquake fanquake added this to the 23.0 milestone Mar 16, 2022
This was referenced Mar 16, 2022
Merged
Merged
Merged
@gruve-p
Copy link
Contributor

gruve-p commented Mar 16, 2022

ACK f541a25

@achow101
Copy link
Member

achow101 commented Mar 16, 2022

Guix build

b2e644c68aabe198b0ad8e632f70fd86c3ae15c012fdf45fcabb257bfddfdd69  guix-build-f541a252f676/output/aarch64-linux-gnu/SHA256SUMS.part
3368e4d06b787221c3d3b3dbd09a4c1477fb8908ed1812e6e3c29c4590129e53  guix-build-f541a252f676/output/aarch64-linux-gnu/bitcoin-f541a252f676-aarch64-linux-gnu-debug.tar.gz
a6927b1ae118f547e1268dcc6966d4cb9f6aa5e6014924eafe371e9f48eb6311  guix-build-f541a252f676/output/aarch64-linux-gnu/bitcoin-f541a252f676-aarch64-linux-gnu.tar.gz
d1e8e6b05e553f733bc55d7a0d6b144169c2e2182484ebaa9c84bb1a4234b3a8  guix-build-f541a252f676/output/arm-linux-gnueabihf/SHA256SUMS.part
65028d30702a0fe072074a16b82633e7b3a3b7b9e9bfc7561e15edad6862b092  guix-build-f541a252f676/output/arm-linux-gnueabihf/bitcoin-f541a252f676-arm-linux-gnueabihf-debug.tar.gz
02e257d7e7b9b0a0b9a668f8933bb2b3cc7443dbd7b000a39ce96d043613c12f  guix-build-f541a252f676/output/arm-linux-gnueabihf/bitcoin-f541a252f676-arm-linux-gnueabihf.tar.gz
45e41f8457bdfd3bfc501f065e7e717ba10ada68044fe16248adf843ddb2afe4  guix-build-f541a252f676/output/arm64-apple-darwin/SHA256SUMS.part
6c1f9b4047a52d79874228c7eccc8a2dcad30b5ed74469066037e6d9f7ccdae9  guix-build-f541a252f676/output/arm64-apple-darwin/bitcoin-f541a252f676-arm64-apple-darwin-unsigned.dmg
516dd9cec4847012201e5e3793250329722465f187f14fb433e58cdda90645c8  guix-build-f541a252f676/output/arm64-apple-darwin/bitcoin-f541a252f676-arm64-apple-darwin-unsigned.tar.gz
d19bfe00e66aac8fa2c988d51825ba437871895769b2ddca9858104ac86e953a  guix-build-f541a252f676/output/arm64-apple-darwin/bitcoin-f541a252f676-arm64-apple-darwin.tar.gz
49032d00a20cfe303c6329a36566c7150c03541c42e9f5b3be6692c0e41cf5d4  guix-build-f541a252f676/output/dist-archive/bitcoin-f541a252f676.tar.gz
6d5f58462ec368f18b897b5c67fecd815be0cd29a6e93ee31d3eeeeddd32f26c  guix-build-f541a252f676/output/powerpc64-linux-gnu/SHA256SUMS.part
f89a390f0effc82ed47d31be167002e0a02ef23e7d467bc2b70603a56d9f6f4f  guix-build-f541a252f676/output/powerpc64-linux-gnu/bitcoin-f541a252f676-powerpc64-linux-gnu-debug.tar.gz
c7d165beda21c240527e9c21ca7eafd7a32f7077ed47cef5f47b6dc1c72c286b  guix-build-f541a252f676/output/powerpc64-linux-gnu/bitcoin-f541a252f676-powerpc64-linux-gnu.tar.gz
46a200ddb05a2ef50a59a2c3f6f0cd256d325a5839f11bb4f80d98464ce5a749  guix-build-f541a252f676/output/powerpc64le-linux-gnu/SHA256SUMS.part
204ee29c955cfa54368bbfe1be74921f44773d0e2d069db4333b92ca1b5ed825  guix-build-f541a252f676/output/powerpc64le-linux-gnu/bitcoin-f541a252f676-powerpc64le-linux-gnu-debug.tar.gz
e70a46f8b2e962b7fad8ffb4eed95e1e979bef60ebdce755e66dfd0ad81e2777  guix-build-f541a252f676/output/powerpc64le-linux-gnu/bitcoin-f541a252f676-powerpc64le-linux-gnu.tar.gz
0916b01d98a3afff4d1786f0f1f5b918bcf581eaea13dbaa99e1ecd228ac9c54  guix-build-f541a252f676/output/riscv64-linux-gnu/SHA256SUMS.part
c40ad5c3d322aa730c99a5c838e1495f53fd83aa5d218c7d93cfe19c9a23d605  guix-build-f541a252f676/output/riscv64-linux-gnu/bitcoin-f541a252f676-riscv64-linux-gnu-debug.tar.gz
befa3aaad5d425a7fe6c3610251609a82b8a92e54dadf66cc04e75af0189e0da  guix-build-f541a252f676/output/riscv64-linux-gnu/bitcoin-f541a252f676-riscv64-linux-gnu.tar.gz
477b7b7680f14e878a39b56be02ea81e197a2f9fc08d0e55fb7677f5cbe3a4b0  guix-build-f541a252f676/output/x86_64-apple-darwin/SHA256SUMS.part
6fe1afd688c35dfcdd6504d3c7d455bbcd12335b35efdb5412d0d0914e8803e3  guix-build-f541a252f676/output/x86_64-apple-darwin/bitcoin-f541a252f676-x86_64-apple-darwin-unsigned.dmg
67c0b6824888f6d114bc0eb1e280a8d9b766bde3092c908e582e29e44f10bc25  guix-build-f541a252f676/output/x86_64-apple-darwin/bitcoin-f541a252f676-x86_64-apple-darwin-unsigned.tar.gz
cfaae76b797d2f9f80ac0469957b12252a080564bdb72ff0071022e3a6d81cd2  guix-build-f541a252f676/output/x86_64-apple-darwin/bitcoin-f541a252f676-x86_64-apple-darwin.tar.gz
1c384e19b33e5b24de528f51b56c1589657e082f847603760cecfb6f76982442  guix-build-f541a252f676/output/x86_64-linux-gnu/SHA256SUMS.part
f547cde3a4679ea856c129eccde23dc111e671cbc1d896b5ea9da14e3429b389  guix-build-f541a252f676/output/x86_64-linux-gnu/bitcoin-f541a252f676-x86_64-linux-gnu-debug.tar.gz
06de04d5791619c2765e8b3894d3ab7d07e9738cd02c568a5b108f8a46bf6b8f  guix-build-f541a252f676/output/x86_64-linux-gnu/bitcoin-f541a252f676-x86_64-linux-gnu.tar.gz
5b80a7b25190cddf959f6cba1a6c7310396d6e4dfc4f27324a419d776fa16cbf  guix-build-f541a252f676/output/x86_64-w64-mingw32/SHA256SUMS.part
559d3b9e74c9614cb6581cc9d98614d82f0b9a34f7ea149469a5066aead160e8  guix-build-f541a252f676/output/x86_64-w64-mingw32/bitcoin-f541a252f676-win64-debug.zip
4f738965fd12f154811c3bbb37b93e251044741d9bf353e13d29f68796329695  guix-build-f541a252f676/output/x86_64-w64-mingw32/bitcoin-f541a252f676-win64-setup-unsigned.exe
358ed3056ecf0b4dd3684645e1a04c84a97f67d27a144b63fda8ac90535256cb  guix-build-f541a252f676/output/x86_64-w64-mingw32/bitcoin-f541a252f676-win64-unsigned.tar.gz
0719e5ebfd4070cbdb30cfa58d03b5491edd6f4fac0b9b15d4b7ff29e9f3617b  guix-build-f541a252f676/output/x86_64-w64-mingw32/bitcoin-f541a252f676-win64.zip

@achow101
Copy link
Member

achow101 commented Mar 16, 2022

ACK f541a25

@fanquake
Copy link
Member Author

fanquake commented Mar 17, 2022

Guix Build:

bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
b2e644c68aabe198b0ad8e632f70fd86c3ae15c012fdf45fcabb257bfddfdd69  guix-build-f541a252f676/output/aarch64-linux-gnu/SHA256SUMS.part
3368e4d06b787221c3d3b3dbd09a4c1477fb8908ed1812e6e3c29c4590129e53  guix-build-f541a252f676/output/aarch64-linux-gnu/bitcoin-f541a252f676-aarch64-linux-gnu-debug.tar.gz
a6927b1ae118f547e1268dcc6966d4cb9f6aa5e6014924eafe371e9f48eb6311  guix-build-f541a252f676/output/aarch64-linux-gnu/bitcoin-f541a252f676-aarch64-linux-gnu.tar.gz
d1e8e6b05e553f733bc55d7a0d6b144169c2e2182484ebaa9c84bb1a4234b3a8  guix-build-f541a252f676/output/arm-linux-gnueabihf/SHA256SUMS.part
65028d30702a0fe072074a16b82633e7b3a3b7b9e9bfc7561e15edad6862b092  guix-build-f541a252f676/output/arm-linux-gnueabihf/bitcoin-f541a252f676-arm-linux-gnueabihf-debug.tar.gz
02e257d7e7b9b0a0b9a668f8933bb2b3cc7443dbd7b000a39ce96d043613c12f  guix-build-f541a252f676/output/arm-linux-gnueabihf/bitcoin-f541a252f676-arm-linux-gnueabihf.tar.gz
45e41f8457bdfd3bfc501f065e7e717ba10ada68044fe16248adf843ddb2afe4  guix-build-f541a252f676/output/arm64-apple-darwin/SHA256SUMS.part
6c1f9b4047a52d79874228c7eccc8a2dcad30b5ed74469066037e6d9f7ccdae9  guix-build-f541a252f676/output/arm64-apple-darwin/bitcoin-f541a252f676-arm64-apple-darwin-unsigned.dmg
516dd9cec4847012201e5e3793250329722465f187f14fb433e58cdda90645c8  guix-build-f541a252f676/output/arm64-apple-darwin/bitcoin-f541a252f676-arm64-apple-darwin-unsigned.tar.gz
d19bfe00e66aac8fa2c988d51825ba437871895769b2ddca9858104ac86e953a  guix-build-f541a252f676/output/arm64-apple-darwin/bitcoin-f541a252f676-arm64-apple-darwin.tar.gz
49032d00a20cfe303c6329a36566c7150c03541c42e9f5b3be6692c0e41cf5d4  guix-build-f541a252f676/output/dist-archive/bitcoin-f541a252f676.tar.gz
6d5f58462ec368f18b897b5c67fecd815be0cd29a6e93ee31d3eeeeddd32f26c  guix-build-f541a252f676/output/powerpc64-linux-gnu/SHA256SUMS.part
f89a390f0effc82ed47d31be167002e0a02ef23e7d467bc2b70603a56d9f6f4f  guix-build-f541a252f676/output/powerpc64-linux-gnu/bitcoin-f541a252f676-powerpc64-linux-gnu-debug.tar.gz
c7d165beda21c240527e9c21ca7eafd7a32f7077ed47cef5f47b6dc1c72c286b  guix-build-f541a252f676/output/powerpc64-linux-gnu/bitcoin-f541a252f676-powerpc64-linux-gnu.tar.gz
46a200ddb05a2ef50a59a2c3f6f0cd256d325a5839f11bb4f80d98464ce5a749  guix-build-f541a252f676/output/powerpc64le-linux-gnu/SHA256SUMS.part
204ee29c955cfa54368bbfe1be74921f44773d0e2d069db4333b92ca1b5ed825  guix-build-f541a252f676/output/powerpc64le-linux-gnu/bitcoin-f541a252f676-powerpc64le-linux-gnu-debug.tar.gz
e70a46f8b2e962b7fad8ffb4eed95e1e979bef60ebdce755e66dfd0ad81e2777  guix-build-f541a252f676/output/powerpc64le-linux-gnu/bitcoin-f541a252f676-powerpc64le-linux-gnu.tar.gz
0916b01d98a3afff4d1786f0f1f5b918bcf581eaea13dbaa99e1ecd228ac9c54  guix-build-f541a252f676/output/riscv64-linux-gnu/SHA256SUMS.part
c40ad5c3d322aa730c99a5c838e1495f53fd83aa5d218c7d93cfe19c9a23d605  guix-build-f541a252f676/output/riscv64-linux-gnu/bitcoin-f541a252f676-riscv64-linux-gnu-debug.tar.gz
befa3aaad5d425a7fe6c3610251609a82b8a92e54dadf66cc04e75af0189e0da  guix-build-f541a252f676/output/riscv64-linux-gnu/bitcoin-f541a252f676-riscv64-linux-gnu.tar.gz
477b7b7680f14e878a39b56be02ea81e197a2f9fc08d0e55fb7677f5cbe3a4b0  guix-build-f541a252f676/output/x86_64-apple-darwin/SHA256SUMS.part
6fe1afd688c35dfcdd6504d3c7d455bbcd12335b35efdb5412d0d0914e8803e3  guix-build-f541a252f676/output/x86_64-apple-darwin/bitcoin-f541a252f676-x86_64-apple-darwin-unsigned.dmg
67c0b6824888f6d114bc0eb1e280a8d9b766bde3092c908e582e29e44f10bc25  guix-build-f541a252f676/output/x86_64-apple-darwin/bitcoin-f541a252f676-x86_64-apple-darwin-unsigned.tar.gz
cfaae76b797d2f9f80ac0469957b12252a080564bdb72ff0071022e3a6d81cd2  guix-build-f541a252f676/output/x86_64-apple-darwin/bitcoin-f541a252f676-x86_64-apple-darwin.tar.gz
1c384e19b33e5b24de528f51b56c1589657e082f847603760cecfb6f76982442  guix-build-f541a252f676/output/x86_64-linux-gnu/SHA256SUMS.part
f547cde3a4679ea856c129eccde23dc111e671cbc1d896b5ea9da14e3429b389  guix-build-f541a252f676/output/x86_64-linux-gnu/bitcoin-f541a252f676-x86_64-linux-gnu-debug.tar.gz
06de04d5791619c2765e8b3894d3ab7d07e9738cd02c568a5b108f8a46bf6b8f  guix-build-f541a252f676/output/x86_64-linux-gnu/bitcoin-f541a252f676-x86_64-linux-gnu.tar.gz
5b80a7b25190cddf959f6cba1a6c7310396d6e4dfc4f27324a419d776fa16cbf  guix-build-f541a252f676/output/x86_64-w64-mingw32/SHA256SUMS.part
559d3b9e74c9614cb6581cc9d98614d82f0b9a34f7ea149469a5066aead160e8  guix-build-f541a252f676/output/x86_64-w64-mingw32/bitcoin-f541a252f676-win64-debug.zip
4f738965fd12f154811c3bbb37b93e251044741d9bf353e13d29f68796329695  guix-build-f541a252f676/output/x86_64-w64-mingw32/bitcoin-f541a252f676-win64-setup-unsigned.exe
358ed3056ecf0b4dd3684645e1a04c84a97f67d27a144b63fda8ac90535256cb  guix-build-f541a252f676/output/x86_64-w64-mingw32/bitcoin-f541a252f676-win64-unsigned.tar.gz
0719e5ebfd4070cbdb30cfa58d03b5491edd6f4fac0b9b15d4b7ff29e9f3617b  guix-build-f541a252f676/output/x86_64-w64-mingw32/bitcoin-f541a252f676-win64.zip

@fanquake fanquake mentioned this pull request Mar 17, 2022
Merged
@fanquake
Copy link
Member Author

fanquake commented Mar 17, 2022

Added 1 additional commit. Should be straightforward to re-ACK.

@laanwj
Copy link
Member

laanwj commented Mar 17, 2022

Code review ACK 61c0216

@laanwj laanwj merged commit 55a60b9 into bitcoin:23.x Mar 17, 2022
@fanquake fanquake deleted the more_macos_backports_rc3 branch March 17, 2022 09:35
@bitcoin bitcoin locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Backport

Projects

None yet

Milestone

23.0

Development

Successfully merging this pull request may close these issues.

5 participants

@fanquake @gruve-p @achow101 @laanwj @hebasto