Skip to content

Conversation

@michaelfolkson
Copy link

@michaelfolkson michaelfolkson commented Mar 16, 2022

In #23288 MarcoFalke highlighted an old BOOST_CHECK that was commented out and replaced by a different BOOST_CHECK. I think this can be deleted and wasn't deliberately left in by achow101.

@achow101
Copy link
Member

ACK 9a5b4d7

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9a5b4d7

@achow101 achow101 merged commit b8992f2 into bitcoin:master Mar 16, 2022
@michaelfolkson michaelfolkson deleted the 2022-03-delete-comment branch March 16, 2022 20:20
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 16, 2022
9a5b4d7 doc: Delete old line of code that was commented out (Michael Folkson)

Pull request description:

  In bitcoin#23288 MarcoFalke [highlighted](https://github.com/bitcoin/bitcoin/pull/23288/files#r739817055) an old BOOST_CHECK that was commented out and replaced by a different BOOST_CHECK. I think this can be deleted and wasn't deliberately left in by achow101.

ACKs for top commit:
  achow101:
    ACK 9a5b4d7
  jonatack:
    ACK 9a5b4d7

Tree-SHA512: 69aa71d362bb190c75d617766f6af945a43211ddb315ccfef5ebab2beefe020032d99f0d0d4b312aa349e605ba712a8bc91d7f0a22427681e08c95f8a6ea7e64
@bitcoin bitcoin locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants