test: use MiniWallet for rpc_createmultisig.py #24587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
approved these changes
Mar 16, 2022
Member
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
Thanks, Concept ACK. Some questions.
maflcko
reviewed
Mar 16, 2022
Contributor
|
Concept ACK. You should squash the commits, see: https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits |
ayush933
force-pushed
the
createmultisig-miniwallet
branch
from
137ac50 to
4ea7c1b
Compare
maflcko
approved these changes
Mar 18, 2022
Contributor
|
Concept ACK |
danielabrozzoni
approved these changes
Mar 19, 2022
Member
danielabrozzoni
left a comment
danielabrozzoni
left a comment
There was a problem hiding this comment.
tACK 4ea7c1b410bc6626a14c2cac8841910bc51e2422 - the code looks good, the test works as intended even when the wallet is disabled.
This test can now be run even with the Bitcoin Core wallet disabled.
ayush933
force-pushed
the
createmultisig-miniwallet
branch
from
4ea7c1b to
2726b60
Compare
michaelfolkson
left a comment
michaelfolkson
left a comment
There was a problem hiding this comment.
Concept ACK
This is one of the tests from #20078 that could use MiniWallet instead of being skipped when the Core wallet is disabled.
maflcko
approved these changes
Mar 23, 2022
Member
|
@danielabrozzoni / @theStack want to re-ACK? |
|
I'll test this and ACK it in the next couple of days. |
Member
|
re-ACK 2726b60 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 2, 2022
2726b60 test: use MiniWallet for rpc_createmultisig.py (Ayush Sharma) Pull request description: This PR enables one of the non-wallet functional tests (rpc_createmultisig.py) to be run even with the Bitcoin Core wallet disabled by using the MiniWallet instead, as proposed in bitcoin#20078 . ACKs for top commit: danielabrozzoni: re-ACK 2726b60 Tree-SHA512: fb0ef22d3f1c161ca5963cb19ce76533ac3941f15102fc0aa2286ef3bec48f219e5934d504b41976f9f295fb6ca582b737e0fea896df4eb964cdaba1b2c91650
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables one of the non-wallet functional tests (rpc_createmultisig.py) to be run even with the Bitcoin Core wallet disabled by using the MiniWallet instead, as proposed in #20078 .