Skip to content

Conversation

@fanquake
Copy link
Member

Re-order legacy and descriptor wallet section.
Installing sqlite isn't required (the version pre-installed on macOS is just as good as what will be installed via brew).
Remove prelude that pointlessly repeats the same info.

Basically the macOS version of #23446.

Includes a small fixup from #23565.

Re-order legacy and descriptor wallet section.
Installing sqlite isn't required.
Remove prelude that pointlessly reqpeats the same info.
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 57f3f5c, I have reviewed the changes and they look OK, I agree they can be merged.

@RandyMcMillan
Copy link
Contributor

ACK 57f3f5c

@maflcko maflcko merged commit e09cf64 into bitcoin:master Mar 17, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 18, 2022
@fanquake fanquake deleted the build_osx_descriptor_legacy_switch branch March 18, 2022 09:54
@bitcoin bitcoin locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants