-
Notifications
You must be signed in to change notification settings - Fork 38.7k
doc: Add template for empty release notes #24583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "2203-docRel-\u{1F31F}"
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
doc/release-notes-empty-template.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also completely don't mention the per-PR changelog here. Is this in purpose?
I'm sometimes not clear on whether we still need it. The release notes tend to be written to such a level of detail nowadays (even low-level changes) which used to be the point of the detailed list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can't hurt, as it is easy to skip the section if not needed?
Added the section to the template for now.
|
Concept ACK
Which note are you referring to here? (the link refers to "Updated settings", which doesn't make it clearer to me). |
It is " Changes to wallet related RPCs can be found in the Wallet section below.". |
|
ACK fa4943e |
cpcommand. Also, this ensures that the "no duplication" note isn't deleted again. (We used to have it in at least the 22.0 and 21.0 release notes: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.21.0.md#updated-settings , but it was lost in the 23.0 notes)