contrib: testgen: remove redundant base58 implementation #24576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
Code review and lightly tested ACK 94c25d47539cf09b6dcb9e5211e5abb7c103725a |
laanwj
reviewed
Apr 4, 2022
laanwj
reviewed
Apr 5, 2022
-BEGIN VERIFY SCRIPT- sed -i 's/chars/b58chars/g' ./test/functional/test_framework/address.py -END VERIFY SCRIPT-
theStack
force-pushed
the
202203-contrib-various_testgen_improvements
branch
from
94c25d4 to
65c49ac
Compare
Member
|
Code review ACK 65c49ac |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the redundant base58 implementation contrib/testgen/base58.py for the test generation script
gen_key_io_test_vectors.pyand uses the one from the test framework instead. Additionally, three other cleanups/improvements are done:OP_*from test framework instead of manually defining themsys.path.append(...)) instead of needing the caller to specifyPYTHONPATH=...on the command line (the same approach is done for the signet miner and the message capture scripts)charstob58charsin the test_framework.address module (is more explicit and makes the diff for the base58 replacement smaller)