Skip to content

Conversation

@fanquake
Copy link
Member

We no-longer link against any Boost libs, so we shouldn't need to use
any Boost linker flags.

We no-longer link against any Boost libs, so we shouldn't need to use
any Boost linker flags.
@fanquake fanquake added the Docs label Mar 10, 2022
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #20610 (doc: update for NetBSD 9.1, add GUI Build Instructions by jarolrod)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8336a06, I have reviewed the code and it looks OK, I agree it can be merged. Also verified that there is no other usage of BOOST_LDFLAGS in our codebase or documentation.

@fanquake fanquake merged commit bb0b39c into bitcoin:master Mar 11, 2022
@fanquake fanquake deleted the remove_boost_ldflags branch March 11, 2022 11:26
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 11, 2022
8336a06 doc: remove Boost LDFLAGS from netBSD build docs (fanquake)

Pull request description:

  We no-longer link against any Boost libs, so we shouldn't need to use
  any Boost linker flags.

ACKs for top commit:
  hebasto:
    ACK 8336a06, I have reviewed the code and it looks OK, I agree it can be merged. Also verified that there is no other usage of `BOOST_LDFLAGS` in our codebase or documentation.

Tree-SHA512: b7814d10cee789903cb3c613631e184a72f5766cda85261b5f99f9ac207348a2a49c92494c8c1d50163494f6b755c503cf51bf083b31f564dae1b0f493c54c2e
@bitcoin bitcoin locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants