Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Mar 9, 2022

openssl is not mentioned as a dependency in the https://github.com/achow101/signapple repo.

GUIX builds on x86_64:

$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
533f65e86f038ede9a665472279fc7569a3c9323c8c9c8f751ec1cb03d181638  guix-build-e857f0bb55b1/output/arm64-apple-darwin/SHA256SUMS.part
835b1b48d139f76213a7289d09bfa05e32d14a5351f8f9b6624059db5c621479  guix-build-e857f0bb55b1/output/arm64-apple-darwin/bitcoin-e857f0bb55b1-arm64-apple-darwin.tar.gz
076b385ec3aa21045a9d3269848ba20ec5e3150bf1e6a6a4f9cb940087588b72  guix-build-e857f0bb55b1/output/arm64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.dmg
9cd50f1fb66b817f76a7dda5db29cab1abe68a8eba5f0192c7e7350ebc160313  guix-build-e857f0bb55b1/output/arm64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.tar.gz
af674d14f616526de8737cf79ab4f4dff81a9737bebf92fd45ebd17b99b560a1  guix-build-e857f0bb55b1/output/dist-archive/bitcoin-e857f0bb55b1.tar.gz
ebea43c2fd7f7883055219c99c96bab5b77c82060d5e977de9be9639fe343cd8  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/SHA256SUMS.part
9d4a93f1a82224b901fabe04081fa15e19692c91b5b53f17af5cab468b1185fe  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.dmg
df3fc3644b4ce51a58b8f527594b5351af1b6f468d3dd929a901094bdec8adeb  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.tar.gz
7f665e8dcb485c71da70cfcff12547dfc801d09dae3133a5e79d5dba2e1b4048  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/bitcoin-e857f0bb55b1-osx64.tar.gz

@laanwj
Copy link
Member

laanwj commented Mar 9, 2022

openssl is not mentioned as a dependency in the https://github.com/achow101/signapple repo.

I did discover that on UNIX systems it has a indirect dependency on openssl or similar though oscrypto. I'm not sure this is relevant here.

If only direct dependencies count, ACK e857f0b.

@fanquake
Copy link
Member

fanquake commented Mar 9, 2022

Guix Build:

bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
533f65e86f038ede9a665472279fc7569a3c9323c8c9c8f751ec1cb03d181638  guix-build-e857f0bb55b1/output/arm64-apple-darwin/SHA256SUMS.part
835b1b48d139f76213a7289d09bfa05e32d14a5351f8f9b6624059db5c621479  guix-build-e857f0bb55b1/output/arm64-apple-darwin/bitcoin-e857f0bb55b1-arm64-apple-darwin.tar.gz
076b385ec3aa21045a9d3269848ba20ec5e3150bf1e6a6a4f9cb940087588b72  guix-build-e857f0bb55b1/output/arm64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.dmg
9cd50f1fb66b817f76a7dda5db29cab1abe68a8eba5f0192c7e7350ebc160313  guix-build-e857f0bb55b1/output/arm64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.tar.gz
af674d14f616526de8737cf79ab4f4dff81a9737bebf92fd45ebd17b99b560a1  guix-build-e857f0bb55b1/output/dist-archive/bitcoin-e857f0bb55b1.tar.gz
ebea43c2fd7f7883055219c99c96bab5b77c82060d5e977de9be9639fe343cd8  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/SHA256SUMS.part
9d4a93f1a82224b901fabe04081fa15e19692c91b5b53f17af5cab468b1185fe  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.dmg
df3fc3644b4ce51a58b8f527594b5351af1b6f468d3dd929a901094bdec8adeb  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.tar.gz
7f665e8dcb485c71da70cfcff12547dfc801d09dae3133a5e79d5dba2e1b4048  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/bitcoin-e857f0bb55b1-osx64.tar.gz

@fanquake fanquake added this to the 24.0 milestone Mar 9, 2022
@achow101
Copy link
Member

ACK e857f0b

Openssl is an indirect dependency via python-oscrypto which already has openssl listed.

@fanquake fanquake merged commit 6fee9de into bitcoin:master Mar 24, 2022
@hebasto hebasto deleted the 220309-openssl branch March 24, 2022 10:58
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 2, 2022
…pple

e857f0b guix: Drop unneeded openssl dependency for signapple (Hennadii Stepanov)

Pull request description:

  `openssl` is not mentioned as a dependency in the https://github.com/achow101/signapple repo.

  #### GUIX builds on `x86_64`:
  ```
  $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
  533f65e86f038ede9a665472279fc7569a3c9323c8c9c8f751ec1cb03d181638  guix-build-e857f0bb55b1/output/arm64-apple-darwin/SHA256SUMS.part
  835b1b48d139f76213a7289d09bfa05e32d14a5351f8f9b6624059db5c621479  guix-build-e857f0bb55b1/output/arm64-apple-darwin/bitcoin-e857f0bb55b1-arm64-apple-darwin.tar.gz
  076b385ec3aa21045a9d3269848ba20ec5e3150bf1e6a6a4f9cb940087588b72  guix-build-e857f0bb55b1/output/arm64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.dmg
  9cd50f1fb66b817f76a7dda5db29cab1abe68a8eba5f0192c7e7350ebc160313  guix-build-e857f0bb55b1/output/arm64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.tar.gz
  af674d14f616526de8737cf79ab4f4dff81a9737bebf92fd45ebd17b99b560a1  guix-build-e857f0bb55b1/output/dist-archive/bitcoin-e857f0bb55b1.tar.gz
  ebea43c2fd7f7883055219c99c96bab5b77c82060d5e977de9be9639fe343cd8  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/SHA256SUMS.part
  9d4a93f1a82224b901fabe04081fa15e19692c91b5b53f17af5cab468b1185fe  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.dmg
  df3fc3644b4ce51a58b8f527594b5351af1b6f468d3dd929a901094bdec8adeb  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.tar.gz
  7f665e8dcb485c71da70cfcff12547dfc801d09dae3133a5e79d5dba2e1b4048  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/bitcoin-e857f0bb55b1-osx64.tar.gz
  ```

ACKs for top commit:
  laanwj:
    If only direct dependencies count, ACK e857f0b.
  achow101:
    ACK e857f0b

Tree-SHA512: 333aab2d538a7e31ba057223f143810fe6f8f612cb3c36e80e78d51bcdad533918662f10909e215455b71ee8d87a18c623dfcf7763e2c6e55bd7f26ad510eaf4
dekm pushed a commit to unigrid-project/daemon that referenced this pull request Oct 27, 2022
…pple

e857f0b guix: Drop unneeded openssl dependency for signapple (Hennadii Stepanov)

Pull request description:

  `openssl` is not mentioned as a dependency in the https://github.com/achow101/signapple repo.

  #### GUIX builds on `x86_64`:
  ```
  $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
  533f65e86f038ede9a665472279fc7569a3c9323c8c9c8f751ec1cb03d181638  guix-build-e857f0bb55b1/output/arm64-apple-darwin/SHA256SUMS.part
  835b1b48d139f76213a7289d09bfa05e32d14a5351f8f9b6624059db5c621479  guix-build-e857f0bb55b1/output/arm64-apple-darwin/bitcoin-e857f0bb55b1-arm64-apple-darwin.tar.gz
  076b385ec3aa21045a9d3269848ba20ec5e3150bf1e6a6a4f9cb940087588b72  guix-build-e857f0bb55b1/output/arm64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.dmg
  9cd50f1fb66b817f76a7dda5db29cab1abe68a8eba5f0192c7e7350ebc160313  guix-build-e857f0bb55b1/output/arm64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.tar.gz
  af674d14f616526de8737cf79ab4f4dff81a9737bebf92fd45ebd17b99b560a1  guix-build-e857f0bb55b1/output/dist-archive/bitcoin-e857f0bb55b1.tar.gz
  ebea43c2fd7f7883055219c99c96bab5b77c82060d5e977de9be9639fe343cd8  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/SHA256SUMS.part
  9d4a93f1a82224b901fabe04081fa15e19692c91b5b53f17af5cab468b1185fe  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.dmg
  df3fc3644b4ce51a58b8f527594b5351af1b6f468d3dd929a901094bdec8adeb  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/bitcoin-e857f0bb55b1-osx-unsigned.tar.gz
  7f665e8dcb485c71da70cfcff12547dfc801d09dae3133a5e79d5dba2e1b4048  guix-build-e857f0bb55b1/output/x86_64-apple-darwin/bitcoin-e857f0bb55b1-osx64.tar.gz
  ```

ACKs for top commit:
  laanwj:
    If only direct dependencies count, ACK e857f0b.
  achow101:
    ACK e857f0b

Tree-SHA512: 333aab2d538a7e31ba057223f143810fe6f8f612cb3c36e80e78d51bcdad533918662f10909e215455b71ee8d87a18c623dfcf7763e2c6e55bd7f26ad510eaf4
@bitcoin bitcoin locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants