qt: English (source) translations update #24438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last-minute update for bitcoin#24434 and bitcoin#24401.
jonatack
reviewed
Feb 24, 2022
Member
There was a problem hiding this comment.
Light review ACK 38020c4
at least, as far as I can tell. Unrelated, saw the following with make translate (clang 15 and gcc 11)
make translate
GEN qt/bitcoinstrings.cpp
protocol.h:379: warning: unterminated character constant
util/strencodings.h:44: warning: unterminated character constant
GEN translate
/home/jon/projects/bitcoin/bitcoin/src/util/strencodings.h:44: Unterminated C++ character
/home/jon/projects/bitcoin/bitcoin/src/protocol.h:379: Unterminated C++ character
/home/jon/projects/bitcoin/bitcoin/src/protocol.h:359: Unbalanced opening brace in C++ code (or abuse of the C++ preprocessor)
/home/jon/projects/bitcoin/bitcoin/src/qt/guiutil.cpp:800: Unterminated C++ character
/home/jon/projects/bitcoin/bitcoin/src/qt/guiutil.cpp:803: Unterminated C++ character
/home/jon/projects/bitcoin/bitcoin/src/qt/guiutil.cpp:804: Unterminated C++ character
/home/jon/projects/bitcoin/bitcoin/src/qt/guiutil.cpp:807: Unterminated C++ character
/home/jon/projects/bitcoin/bitcoin/src/qt/guiutil.cpp:800: Unbalanced opening parenthesis in C++ code (or abuse of the C++ preprocessor)
Updating 'qt/locale/bitcoin_en.ts'...
Found 1100 source text(s) (0 new and 1100 already existing)
GEN translate
Member
Author
|
I think the warnings are harmless. They're thrown by |
fanquake
approved these changes
Feb 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last-minute update for #24434 and #24401.