-
Notifications
You must be signed in to change notification settings - Fork 38.7k
doc: release process chainparams updates #24424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: release process chainparams updates #24424
Conversation
7e0d5ca to
2016c20
Compare
|
Updated per @laanwj feedback (good ideas, thanks). Edit: repushed with a couple edits after re-review. |
2016c20 to
bba0655
Compare
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK bba0655
Updates improve documentation and I could not find any issues.
|
Other things to add maybe:
|
|
It might also be worth writing a script to fetch these values based on a given height, both for reviewers and the maintainer. |
|
Some of the commits here can be dropped. i.e 4b5b011c1d0eba8a432e067c28278f22c18689ff adds a number of |
Yes, the commit specifying the chains can be moved after the reorganization to reduce the diff. I'm reworking to incorporate the latest feedback here and the other items I've noticed. Edit: moved after. |
Yes, automation would be even better. There's quite some scope for reducing human error-proneness and pitfalls here. That said, documenting what we really want to be done is the first step. |
bba0655 to
9560757
Compare
Thanks, I've attempted to address these along with other how-to clarifications. I wasn't sure about #24418 (comment), though. |
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reACK 9560757
|
ACK 9560757adc90938b54148e3921aacfaa4aa51be6 |
brunoerg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9560757adc90938b54148e3921aacfaa4aa51be6
9560757 to
74743ad
Compare
|
Thanks for reviewing! Addressed @laanwj's feedback, fixed an indentation, and reordered the directories to exclude in the
|
brunoerg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-ACK 74743ad
|
Concept ACK |
|
ACK 74743ad |
Release process updates, fixes and clarifications regarding updating the chainparams: