Skip to content

Conversation

@laanwj
Copy link
Member

@laanwj laanwj commented Feb 22, 2022

Update chain parameters for upcoming major release. See doc/release-process.md for review instructions.

  • m_assumed_blockchain_size, m_assumed_chain_state_size:
bitcoin$ du -h .
105M    ./blocks/index
415G    ./blocks
4.5G    ./chainstate
420G    .
bitcoin$ python3
Python 3.9.10 (main, Jan 16 2022, 17:12:18)
[GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> 420 * 1.1
462.00000000000006
>>> 5 * 1.1
5.5
  • chainTxData:
cli getchaintxstats 4096 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
{
  "time": 1645542140,
  "txcount": 712531200,
  "window_final_block_hash": "000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091",
  "window_final_block_height": 724466,
  "window_block_count": 4096,
  "window_tx_count": 6950257,
  "window_interval": 2404071,
  "txrate": 2.891036496010309
}
  • nMinimumChainWork, defaultAssumeValid:
$ cli getblockhash 724466 # was two from the tip at the time
000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
$ cli getblockheader 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
{
  "hash": "000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091",
  "confirmations": 3,
  "height": 724466,
  "version": 939515908,
  "versionHex": "37ffe004",
  "merkleroot": "35a08d9647972e7c3ec39ee7f4ab434f03445de7c446a4d1acc1254b4546bbbe",
  "time": 1645542140,
  "mediantime": 1645539567,
  "nonce": 188699556,
  "bits": "170a1078",
  "difficulty": 27967152532434.23,
  "chainwork": "00000000000000000000000000000000000000002927cdceccbd5209e81e80db",
  "nTx": 1948,
  "previousblockhash": "000000000000000000075e26c23c2ecec4e34699411ccd712ff6f2d252f65a78",
  "nextblockhash": "0000000000000000000905369cd69f68323e3e8da2933a78bea0b2cdb8baa89f"
}

@laanwj laanwj added this to the 23.0 milestone Feb 22, 2022
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #21702 (Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d8a8b54 update ChainTxData for testnet and signet too? (they were last updated in eeddd1c)

same for nMinimumChainWork and defaultAssumeValid

Copy link
Member

@jonatack jonatack Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(side note, I have 41.4 GiB of /indexes on mainnet (4 GiB on testnet), wonder if that space ought to be taken into account somewhere)

Copy link
Member Author

@laanwj laanwj Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do it seperately. I don't have any testnet node at the moment, mainnet is definitely the one requiring the more thorough review/testing.
Edit: all three networks are now covered

(side note, I have 41.4 GiB of /indexes on mainnet (4 GiB on testnet), wonder if that space ought to be taken into account somewhere)

Good point, but I'm simply following the release process here. It could be updated to include indexes, but I don't have any indexes myself, I guess we assume a default setup without them? That makes some sense for new users (remember, this is for the GUI).

Copy link
Member Author

@laanwj laanwj Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be 4096 blocks? The reason I changed this to 4320 is that it's what getchaintxstats returns by default, but it seems we've always explicitly used 4096.

Edit: updated to 4096 just to be sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why 28 days (4096) was used instead of the getchaintxstats default of 30 (4320).

@laanwj laanwj force-pushed the 2022-02-chainparams-update branch from 7d4d5ef to 7611fcb Compare February 23, 2022 15:17
@laanwj
Copy link
Member Author

laanwj commented Feb 23, 2022

Changed to getchaintxstats 4096 (instead of 4320) because that's what we've always done.

@sdaftuar
Copy link
Member

sdaftuar commented Feb 23, 2022

My testnet data (I just used the current tip -- should I go back a few weeks?)

# du -h testnet3
335M	testnet3/blocks/index
29G	testnet3/blocks
1.4G	testnet3/chainstate
59G	testnet3
# # bin/bitcoin-cli -testnet getchaintxstats 4096 00000000d18cfe81cbeea665076807789bd8f831d557632e635bc6e3c003069e
{
  "time": 1645635119,
  "txcount": 62226341,
  "window_final_block_hash": "00000000d18cfe81cbeea665076807789bd8f831d557632e635bc6e3c003069e",
  "window_final_block_height": 2163398,
  "window_block_count": 4096,
  "window_tx_count": 44718,
  "window_interval": 579399,
  "txrate": 0.07717997442177152
}
# bin/bitcoin-cli -testnet getblockhash 2163398
00000000d18cfe81cbeea665076807789bd8f831d557632e635bc6e3c003069e

# bin/bitcoin-cli -testnet getblockheader 00000000d18cfe81cbeea665076807789bd8f831d557632e635bc6e3c003069e
{
  "hash": "00000000d18cfe81cbeea665076807789bd8f831d557632e635bc6e3c003069e",
  "confirmations": 1,
  "height": 2163398,
  "version": 536870912,
  "versionHex": "20000000",
  "merkleroot": "098571ff08c01435151059a176aa8cecb3c374f7803322b7a4e61202aaf225fd",
  "time": 1645635119,
  "mediantime": 1645632662,
  "nonce": 2157408116,
  "bits": "1d00ffff",
  "difficulty": 1,
  "chainwork": "0000000000000000000000000000000000000000000006480a8f8cd1a50d40b4",
  "nTx": 2,
  "previousblockhash": "0000000077b52bb2803f93dfc079c23904f5c5f0a68d693d44f5a4195e135670"
}

Edit: going back 20000 blocks:

# bin/bitcoin-cli -testnet getblockhash 2143398
00000000000163cfb1f97c4e4098a3692c8053ad9cab5ad9c86b338b5c00b8b7
# bin/bitcoin-cli -testnet getblockheader 00000000000163cfb1f97c4e4098a3692c8053ad9cab5ad9c86b338b5c00b8b7
{
  "hash": "00000000000163cfb1f97c4e4098a3692c8053ad9cab5ad9c86b338b5c00b8b7",
  "confirmations": 20002,
  "height": 2143398,
  "version": 536870916,
  "versionHex": "20000004",
  "merkleroot": "860811ef213234164a47bbdfc412c698fae84a2f9cf045983c7ada7acda6e894",
  "time": 1644883096,
  "mediantime": 1644883056,
  "nonce": 3371479007,
  "bits": "1c32b240",
  "difficulty": 5.049602219097336,
  "chainwork": "00000000000000000000000000000000000000000000064728c7be6fe4b2f961",
  "nTx": 1,
  "previousblockhash": "00000000000151e849c468a1861b4683f81fccdbd84b555ccba31ca34212c6c5",
  "nextblockhash": "000000001b45803f50e27a283c8575bf159add02c971f9602608d54d688c7798"
}

@laanwj
Copy link
Member Author

laanwj commented Feb 23, 2022

@sdaftuar Thanks!

My testnet data (I just used the current tip -- should I go back a few weeks?)

The release process mentions "Testnet should be set some tens of thousands back from the tip due to reorgs there" for nMinimumChainWork and defaultAssumeValid specifically, not the other stats. I don't know how relevant this still is.

@ghost
Copy link

ghost commented Feb 23, 2022

Testnet

m_assumed_blockchain_size and m_assumed_chain_state_size

du | Sort-Object -Property "Size(MB)" -Descending

Name                 Size(MB)
----                 --------
blocks               29594.67
indexes               3608.49
chainstate            1408.83
tor                     10.44
debug.old.log           10.03
debug.log                9.26
wallet.dat                2.2
database                    2
peers.dat                0.48
fee_estimates.dat        0.24

chainTxData

getchaintxstats

{
  "time": 1645636320,
  "txcount": 62226436,
  "window_final_block_hash": "00000000cdec5e424755bc1c05d7c410816e67df14112b383a642823f8efc647",
  "window_final_block_height": 2163399,
  "window_block_count": 4320,
  "window_tx_count": 45780,
  "window_interval": 592666,
  "txrate": 0.07724418137703191
}

nMinimumChainWork and defaultAssumeValid

getblockhash 2113399

00000000004d479629eed9a48bb26018e9ee2cd96c27e1671b5e1912af50b55a

getblockheader 00000000004d479629eed9a48bb26018e9ee2cd96c27e1671b5e1912af50b55a

{
  "hash": "00000000004d479629eed9a48bb26018e9ee2cd96c27e1671b5e1912af50b55a",
  "confirmations": 50001,
  "height": 2113399,
  "version": 549453824,
  "versionHex": "20c00000",
  "merkleroot": "58f843b066e6a924ba5d9b09486547b3aea5dc5ae26af7c8b7598c7cb729d769",
  "time": 1639108042,
  "mediantime": 1639108033,
  "nonce": 1736346435,
  "bits": "1c03fffc",
  "difficulty": 64,
  "chainwork": "00000000000000000000000000000000000000000000061eff7f8ad70d987929",
  "nTx": 1,
  "previousblockhash": "0000000000a9f4e47cfb6984eee25f146123db1a752eeed428417e369a55bc69",
  "nextblockhash": "00000000007ad25fa0d4835e2bc0cce5272933a7438262a7d616874d3d76732a"
}

@laanwj
Copy link
Member Author

laanwj commented Feb 23, 2022

Signet:

$ du -h
56M     ./chainstate
4.0K    ./wallets
13M     ./blocks/index
388M    ./blocks
453M    .
$ src/bitcoin-cli -signet getchaintxstats 4096
{
  "time": 1645631279,
  "txcount": 1257429,
  "window_final_block_hash": "0000003d9144c56ac110ae04a0c271a0acce2f14f426b39fdf0d938c96d2eb09",
  "window_final_block_height": 78789,
  "window_block_count": 4096,
  "window_tx_count": 338057,
  "window_interval": 2432697,
  "txrate": 0.1389638742514995
}
$ src/bitcoin-cli -signet getblockhash 78788
00000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef
$ src/bitcoin-cli -signet getblockheader 00000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef
{
  "hash": "00000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef",
  "confirmations": 2,
  "height": 78788,
  "version": 536870912,
  "versionHex": "20000000",
  "merkleroot": "1ab0ba555287a8e81d9a2917d92d7c4a985f6cf455ae155dadaa9b66c80719dc",
  "time": 1645631237,
  "mediantime": 1645624966,
  "nonce": 23153229,
  "bits": "1e015f73",
  "difficulty": 0.002845317866312478,
  "chainwork": "000000000000000000000000000000000000000000000000000000de26b0e471",
  "nTx": 8,
  "previousblockhash": "000000b34d7f0abb0f4b15c59f7fc8d1c646322189cd0450fdbdbe74db75916b",
  "nextblockhash": "0000003d9144c56ac110ae04a0c271a0acce2f14f426b39fdf0d938c96d2eb09"
}

@laanwj laanwj force-pushed the 2022-02-chainparams-update branch from 7611fcb to 4f87a2d Compare February 23, 2022 16:01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091 (assume valid block hash)

Copy link
Member

@achow101 achow101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4f87a2d32f2018406f4a70d5256d635ba51696a9

@jamesob
Copy link
Contributor

jamesob commented Feb 23, 2022

ACK 4f87a2d

Only checked mainnet:

% rpc getblockhash 724466
000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091

% rpc getchaintxstats 4096 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
{
  "time": 1645542140,
  "txcount": 712531200,
  "window_final_block_hash": "000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091",
  "window_final_block_height": 724466,
  "window_block_count": 4096,
  "window_tx_count": 6950257,
  "window_interval": 2404071,
  "txrate": 2.891036496010309
}

@laanwj
Copy link
Member Author

laanwj commented Feb 24, 2022

I think the most important thing still to test here is, especially for mainnet's nMinimumChainWork and defaultAssumeValid update:

This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect that causes rejection of blocks in the past history.

I did not check this, not sure anyone else did.

@jonatack
Copy link
Member

jonatack commented Feb 24, 2022

I think the most important thing still to test here is, especially for mainnet's nMinimumChainWork and defaultAssumeValid update:

This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect that causes rejection of blocks in the past history.

Launched it. Might take awhile.

@laanwj
Copy link
Member Author

laanwj commented Feb 24, 2022

Launched it. Might take awhile.

Thanks!

Edit: re-pushed with the testnet assumed blockchain size change undone.

- `m_assumed_chain_state_size` doesn't seem to need to be changed for mainnet.
- No change needed for testnet/signet.

Co-authored-by: Suhas Daftuar <[email protected]>
@laanwj laanwj force-pushed the 2022-02-chainparams-update branch from 4f87a2d to dbbacb2 Compare February 24, 2022 13:07
Copy link
Member

@Sjors Sjors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK dbbacb2ac86a996c219477c5797e365112612608 for mainnet and signet, but not testnet

Why don't we use the same block for assume-valid and chainTxData on testnet and signet?

I verified the above values on an existing node, did not do a fresh IBD.

@laanwj laanwj force-pushed the 2022-02-chainparams-update branch from dbbacb2 to dca693e Compare February 24, 2022 15:19
@Sjors
Copy link
Member

Sjors commented Feb 24, 2022

ACK dca693e

PGP signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK dca693e08e66279c5497cb3d30285ed41ae6983c
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE7ZvfetalXiMuhFJCV/+b28wwEAkFAmIXpyYACgkQV/+b28ww
EAn0ZxAAn0BJay+iFX30/BbzX4ymp/MRjHlmVDJMgRZxJbFrj3UG1J9l+MTq25TN
/2r7MRz4C6LK/Vo5y0nkGagFAyNSnCJq1Sp5sSrPDOwLxh2Oyfcy3HFvNtUa48Gw
jQLs3r+TsvnOxZYgvyS2rxn7hQp75DIJNOWiIsfkXFbg9YBsll0yJL0du9m5DGyh
HVlpMzoGHgcBE5Xmtwo0zoOdLC2VoqrwW1PedA7Gwavi2uvBzTJp0euu1rbtrUKw
Ly3euZsOmstRN6x2OdPH1K193F5SliD77UDHT5a9EZtsfMB4YvnUfDr/3ojeUgrW
v65HGk5NGOlRizAqnfEgYTEvja4niB+rK38bnqhx2WOR0eFhaVCMZ8xiPPhnMl4u
VlsRwMomTlyRGDy347G2KCsANmil672l5dLG++/MDgN/A10FlPtFnh71ysLBBL/b
NCmzOSnOfQot1fxVqJH7hvk5PkLDfn6t9HpP0B1jUflWCix3NuRnpASUGD0koBcQ
zzJuymD9UOLr0gKls7OfAS+Xyrf4ochJdnjkdi0wpQOlGZbC6nZpAHE8ITo3KTAK
4iL09n+ycv1p/NJyDdbws8qriioJ9zvpeBs+fhkYLEcu55wMx3JK6h5hr1C9IzHA
waiZocPYpb4GP0cpSON+fbzNuWWiKrt1B/L3x/hRuQqJE0j/a38=
=MQ9E
-----END PGP SIGNATURE-----

One way to fetch my key:

gpg -v --auto-key-locate=clear,wkd --locate-key [email protected]

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK dca693e

Testnet only (with and without assumevalid re-index-chainstate)

Agree with @Sjors that we could use assumevalid block for ChainTxData

Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK dca693e -- only checked mainnet (on muliple nodes). Didn't do a reindex.

PGP signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK dca693e08e66279c5497cb3d30285ed41ae6983c

Block 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091 is in main chain and has 301
confirmations at the time of writing. The chain work at this block is 00000000000000000000000000000000000000002927cdceccbd5209e81e80db.
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEWQtykmla/6W2csuy4T/BRc0/QwQFAmIXtHEACgkQ4T/BRc0/
QwQ/JgwAxgT+Z+HaRwrmxZDr3xkH8vS6hUWgvOUMsMrJ3Vs9OsbJ/seYRN0QJzTK
Z30PuQqFKJBa7Jh9TU2EHLW7VHMLfjY+zXZywVQYH4NbDKPlhTlSzdndn84dUV5g
vKBwzvlDwzvHTTUsiI0zMWduLb67FSTkAL/SUjC3z32UkF1fPj2WwTbgrVFTnI/j
jTnRmZ+/B1VNWgVmIIqZ8cmUoBPGc8YUb6PM/j6erMPjiWXyesCL2NFEJqJxwRsz
n4NFOdzizT7ucGvetvhGQCp8OGuTEkDxWOHDsHCl+j0NcyE9ZvM5CGVojSXMQCEq
RgKjecnRtg+uYPFV1AoJpOIjDELSfrnHZ4PsC+vJ3RBK+fsqAI89Ne0w1zDgSLzc
Z73twom4OVyIAL9Jv/nVhTm/llq5mgSenh0uszIDLsNgbSsI42zxblIFQ6jgdQYd
377c/DCDe0CE73ViU/ATbS2VFuTx+C9iU2mAAO/hrOHIGHyVFr6Gha0PPOK3wFn8
ofJvxRAu
=viT5
-----END PGP SIGNATURE-----

@achow101
Copy link
Member

ACK dca693e

@bitcoin bitcoin deleted a comment from Pragmatic2021 Feb 24, 2022
@bitcoin bitcoin deleted a comment from Pragmatic2021 Feb 24, 2022
consensus.nMinimumChainWork = uint256S("0x0000000000000000000000000000000000000000000000000000008546553c03");
consensus.defaultAssumeValid = uint256S("0x000000187d4440e5bff91488b700a140441e089a8aaea707414982460edbfe54"); // 47200
consensus.nMinimumChainWork = uint256S("0x000000000000000000000000000000000000000000000000000000de26b0e471");
consensus.defaultAssumeValid = uint256S("0x00000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef"); // 78788
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the same values for signet with reindex-chainstate and assumevalid=0

$ ./src/bitcoin-cli -signet getblockhash 78788
00000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef

$ ./src/bitcoin-cli -signet getblockheader 00000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef
{
  "hash": "00000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef",
  "confirmations": 166,
  "height": 78788,
  "version": 536870912,
  "versionHex": "20000000",
  "merkleroot": "1ab0ba555287a8e81d9a2917d92d7c4a985f6cf455ae155dadaa9b66c80719dc",
  "time": 1645631237,
  "mediantime": 1645624966,
  "nonce": 23153229,
  "bits": "1e015f73",
  "difficulty": 0.002845317866312478,
  "chainwork": "000000000000000000000000000000000000000000000000000000de26b0e471",
  "nTx": 8,
  "previousblockhash": "000000b34d7f0abb0f4b15c59f7fc8d1c646322189cd0450fdbdbe74db75916b",
  "nextblockhash": "0000003d9144c56ac110ae04a0c271a0acce2f14f426b39fdf0d938c96d2eb09"
}

@maflcko maflcko merged commit 40ab879 into bitcoin:master Feb 28, 2022
@jonatack
Copy link
Member

Launched it. Might take awhile.

Thanks!

FWIW after 4 days, I am only at 33% verification progress on mainnet.

@Rspigler
Copy link
Contributor

Rspigler commented Mar 6, 2022

Post-merge ACK with assumevalid=0

  • m_assumed_blockchain_size, m_assumed_chain_state_size

/.bitcoin$ du -h
105M ./blocks/index
418G ./blocks
4.5G ./chainstate
44K ./v22 Descriptor Compiled Tested
35G ./indexes/txindex
123M ./indexes/coinstats/db
123M ./indexes/coinstats
81M ./indexes/blockfilter/basic/db
7.3G ./indexes/blockfilter/basic
7.3G ./indexes/blockfilter
42G ./indexes
464G .
user@Bitcoin:~/.bitcoin$ python3
Python 3.9.2 (default, Feb 28 2021, 17:03:44)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
464 * 1.1
510.40000000000003
5 * 1.1
5.5

I calculated 510G instead of your 460G because I included the optional indexes (txindex, coinstats, and blockfilter). Might want to change in #24424

  • chainTxData

getchaintxstats 4096 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
{
"time": 1645542140,
"txcount": 712531200,
"window_final_block_hash": "000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091",
"window_final_block_height": 724466,
"window_block_count": 4096,
"window_tx_count": 6950257,
"window_interval": 2404071,
"txrate": 2.891036496010309
}

✔️

  • nMinimumChainWork, defaultAssumeValid

getblockhash 724466
000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
getblockheader 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
{
"hash": "000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091",
"confirmations": 1618,
"height": 724466,
"version": 939515908,
"versionHex": "37ffe004",
"merkleroot": "35a08d9647972e7c3ec39ee7f4ab434f03445de7c446a4d1acc1254b4546bbbe",
"time": 1645542140,
"mediantime": 1645539567,
"nonce": 188699556,
"bits": "170a1078",
"difficulty": 27967152532434.23,
"chainwork": "00000000000000000000000000000000000000002927cdceccbd5209e81e80db",
"nTx": 1948,
"previousblockhash": "000000000000000000075e26c23c2ecec4e34699411ccd712ff6f2d252f65a78",
"nextblockhash": "0000000000000000000905369cd69f68323e3e8da2933a78bea0b2cdb8baa89f"
}

✔️

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the most important thing still to test here is, especially for mainnet's nMinimumChainWork and defaultAssumeValid update:

This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect that causes rejection of blocks in the past history.

After 11 days my node completed reindex-chainstate with assumevalid=0 on mainnet and confirms the same result as this pull.

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Sep 6, 2022
767d825 Update chainparams for 24.0 release (Janna)

Pull request description:

  Update chain parameters for upcoming major release.
  See [doc/release-process.md](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md) and bitcoin#24418 for review instructions.

  fixes bitcoin#25921

ACKs for top commit:
  Sjors:
    tACK 767d825
  achow101:
    utACK 767d825

Tree-SHA512: 153390203c76c981cc41629a27ec3e52fec089c7ce6edba3dd4d77c875c7d8afcae64be2bd9bc8af73f70c2dc0a08666f2986ac82c9fd536b0fded10fd8dec3d
@bitcoin bitcoin locked and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants