wallet: Add external-signer-support specific error message #24401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapsk
approved these changes
Feb 20, 2022
Contributor
|
Not related to this PR, but what I noticed - it seems there is no normal way of unloading wallet in this case, bitcoind / bitcoin-qt will refuse to start. Only workaround is to manually edit settings.json and remove it from there. |
brunoerg
approved these changes
Feb 22, 2022
Member
|
ACK 7f3a6a9 |
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
Feb 24, 2022
Last-minute update for bitcoin#24434 and bitcoin#24401.
fanquake
added a commit
to bitcoin-core/gui
that referenced
this pull request
Feb 24, 2022
38020c4 qt: English (source) translations update (laanwj) Pull request description: Last-minute update for bitcoin/bitcoin#24434 and bitcoin/bitcoin#24401. ACKs for top commit: jonatack: Light review ACK 38020c4 fanquake: ACK 38020c4 Tree-SHA512: 6729700316364cbe78d5b026b0dde7e46fa0df811d7a7ae55d480cc9d2187e9173f3edcc2d7d643022beb6292d9aa6e10b05e6c07a80c95f3814bf23820d272f
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 24, 2022
…or message 7f3a6a9 wallet: Add external-signer-support specific error message (Hennadii Stepanov) Pull request description: On master (5f44c5c) an attempt to load an external signer wallet using Bitcoin Core compiled without external signer support fails with the following log messages: ``` 2022-02-20T19:01:11Z [qt-walletctrl] Using SQLite Version 3.31.1 2022-02-20T19:01:11Z [qt-walletctrl] Using wallet /home/hebasto/.bitcoin/testnet3/wallets/coldcard-0220 2022-02-20T19:01:11Z [qt-walletctrl] init message: Loading wallet… 2022-02-20T19:01:11Z [qt-walletctrl] [coldcard-0220] Error: External signer wallet being loaded without external signer support compiled 2022-02-20T19:01:11Z [qt-walletctrl] [coldcard-0220] Releasing wallet ``` While log messages are good, a message in the GUI window is completely misleading:  This PR fixes this issue:  ACKs for top commit: achow101: ACK 7f3a6a9 kristapsk: ACK 7f3a6a9 brunoerg: crACK 7f3a6a9 Tree-SHA512: a4842751c0ca8a37ccc3ea00503678f6b712a7f53d6cbdc07ce02dcb85ca8a94890d1c2da20307be043faa347747abeba29185c88ba12edd5253bfca56531585
Member
|
janus
pushed a commit
to BitgesellOfficial/bitgesell
that referenced
this pull request
Jul 24, 2022
Last-minute update for bitcoin/bitcoin#24434 and bitcoin/bitcoin#24401.
backpacker69
pushed a commit
to peercoin/peercoin
that referenced
this pull request
Jan 18, 2023
Last-minute update for bitcoin/bitcoin#24434 and bitcoin/bitcoin#24401.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master (5f44c5c) an attempt to load an external signer wallet using Bitcoin Core compiled without external signer support fails with the following log messages:
While log messages are good, a message in the GUI window is completely misleading:
This PR fixes this issue: