Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Feb 20, 2022

On master (5f44c5c) Boost.Process check false fails without the -lpthread flag.

$ grep -C 2 pthread_detach config.log 
/usr/bin/ld: /tmp/cczCQfQv.o: in function `boost::asio::detail::posix_global_impl<boost::asio::system_context>::~posix_global_impl()':
conftest.cpp:(.text._ZN5boost4asio6detail17posix_global_implINS0_14system_contextEED2Ev[_ZN5boost4asio6detail17posix_global_implINS0_14system_contextEED5Ev]+0xa3): undefined reference to `pthread_join'
/usr/bin/ld: conftest.cpp:(.text._ZN5boost4asio6detail17posix_global_implINS0_14system_contextEED2Ev[_ZN5boost4asio6detail17posix_global_implINS0_14system_contextEED5Ev]+0xc4): undefined reference to `pthread_detach'
collect2: error: ld returned 1 exit status
configure:26674: $? = 1

Not required for Boost 1.74+.

@hebasto hebasto changed the title 220220 boost build: Fix Boost.Process check Feb 20, 2022
@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 20, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #24415 (build: Fix Boost.Process test for Boost 1.78 by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Member

@Sjors Sjors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2d911f2

Unfortunately this change doesn't fix the broken Boost.Process on macOS for Homebrew boost 1.78 so I'll open another issue for that.

@hebasto hebasto changed the title build: Fix Boost.Process check build: Fix Boost.Process check for Boost 1.73 and older Feb 22, 2022
@hebasto
Copy link
Member Author

hebasto commented Feb 22, 2022

Updated 2d911f2 -> 2d0d0c5 (pr24397.02 -> pr24397.03, diff):

# -Wno-psabi is to disable ABI warnings: "note: parameter passing for argument of type ... changed in GCC 7.1"
# This could be removed once the ABI change warning does not show up by default
export BITCOIN_CONFIG="--enable-reduce-exports CXXFLAGS=-Wno-psabi"
export BITCOIN_CONFIG="--enable-external-signer --enable-reduce-exports CXXFLAGS=-Wno-psabi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add this to BITCOIN_CONFIG_ALL and then opt out in the windows build with --disable-external-signer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated.

@hebasto
Copy link
Member Author

hebasto commented Feb 22, 2022

Updated 2d0d0c5 -> 774323e (pr24397.03 -> pr24397.04, diff):

@maflcko maflcko modified the milestone: 23.0 Feb 22, 2022
@hebasto
Copy link
Member Author

hebasto commented Feb 22, 2022

@MarcoFalke Why removed this from the 23.0 milestone?

Otherwise, our Guix binaries will lack external signer support.

@maflcko maflcko added this to the 23.0 milestone Feb 22, 2022
@maflcko
Copy link
Member

maflcko commented Feb 22, 2022

I wasn't aware this affects guix builds

@hebasto
Copy link
Member Author

hebasto commented Feb 22, 2022

I wasn't aware this affects guix builds

It does because we use boost 1.71.0 in depends.

@hebasto
Copy link
Member Author

hebasto commented Feb 22, 2022

Guix builds:

$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
6d3bc8aea9ba022a0cb7171b9a690a9c5798e838fd7f3c73212c33066cbad3f7  guix-build-774323e378ac/output/aarch64-linux-gnu/SHA256SUMS.part
d35538cf88e4862cd7d48c048d0e78547f5a44b09aa90b2cfa797530c193d854  guix-build-774323e378ac/output/aarch64-linux-gnu/bitcoin-774323e378ac-aarch64-linux-gnu-debug.tar.gz
8887d905d2d690f4f86a40992379db80732cd54cbb01ad142e4945c7ca553690  guix-build-774323e378ac/output/aarch64-linux-gnu/bitcoin-774323e378ac-aarch64-linux-gnu.tar.gz
544271d9bc866b4525bf3b2260605043ac7e9fed43802e490e2ca0219c59d0a9  guix-build-774323e378ac/output/arm-linux-gnueabihf/SHA256SUMS.part
0329772e725275e73235087ca6d0291947f4bb1800bd70653b055829cae01b62  guix-build-774323e378ac/output/arm-linux-gnueabihf/bitcoin-774323e378ac-arm-linux-gnueabihf-debug.tar.gz
28a5fa4c9150095084b02345f745d07e97a2633b68da1dc3eb6f4c280b516787  guix-build-774323e378ac/output/arm-linux-gnueabihf/bitcoin-774323e378ac-arm-linux-gnueabihf.tar.gz
48c425c5a80d18379883d7ba5db910d1031a34430b9bfe31e9ffb595ab6bd6ed  guix-build-774323e378ac/output/arm64-apple-darwin/SHA256SUMS.part
85aee9958c3ca195b3908328c792c8aa46ab3af488923afd0b149f297e05ff93  guix-build-774323e378ac/output/arm64-apple-darwin/bitcoin-774323e378ac-arm64-apple-darwin.tar.gz
fc4c40ade7b00377f64b728f8a19cfc6939a56e6f966d3b99b6c373d9c90ecd4  guix-build-774323e378ac/output/arm64-apple-darwin/bitcoin-774323e378ac-osx-unsigned.dmg
86bb7442b012585c9751c9a937df3d77c1fb2e45e40f9962cd79f55fd0bc2aa5  guix-build-774323e378ac/output/arm64-apple-darwin/bitcoin-774323e378ac-osx-unsigned.tar.gz
f7b04de225580810c9e5f8999f2e854a36b1fbe5d7c464b2fa5339f831f9fe74  guix-build-774323e378ac/output/dist-archive/bitcoin-774323e378ac.tar.gz
1bce7fdb529f35dedb239ed2c6de1f611caeabdad309a49df26feb9b6e76d370  guix-build-774323e378ac/output/powerpc64-linux-gnu/SHA256SUMS.part
f3460faf9724470f7c3c70785c1ef3f5d344f71e4230687beab8148843c7041b  guix-build-774323e378ac/output/powerpc64-linux-gnu/bitcoin-774323e378ac-powerpc64-linux-gnu-debug.tar.gz
26b8b4bf5f160c5b5926d60346842d65d15e26aae60fec7bac17e144e3bb3f2c  guix-build-774323e378ac/output/powerpc64-linux-gnu/bitcoin-774323e378ac-powerpc64-linux-gnu.tar.gz
72ecb72767d46c26b02ddb9a541e7504d6e84137283f229132728179957a7260  guix-build-774323e378ac/output/powerpc64le-linux-gnu/SHA256SUMS.part
68ff1181a88ad9de08e0310c73f81cf3ceed2db7810ab1059eed8acbc20bac4a  guix-build-774323e378ac/output/powerpc64le-linux-gnu/bitcoin-774323e378ac-powerpc64le-linux-gnu-debug.tar.gz
e691a201d071abe1fb7122fffdf8916bd5a2b01475f937bc37d1004cf773c5ef  guix-build-774323e378ac/output/powerpc64le-linux-gnu/bitcoin-774323e378ac-powerpc64le-linux-gnu.tar.gz
8261d6b583d33f36f0e515064c6e1278054e09fa2eb779a89b25dc5f964d5f64  guix-build-774323e378ac/output/riscv64-linux-gnu/SHA256SUMS.part
230981ac50dd56d5914b726364da1bda0766addb5cc16c32c37ea9e3c41cebee  guix-build-774323e378ac/output/riscv64-linux-gnu/bitcoin-774323e378ac-riscv64-linux-gnu-debug.tar.gz
f8c634f97a08f9f359b32328146752fd00621900d14e02ea4da2d9b556e45976  guix-build-774323e378ac/output/riscv64-linux-gnu/bitcoin-774323e378ac-riscv64-linux-gnu.tar.gz
b55cf1d4a77c4f096a08ed042da5602d98e820d3b7c2bb9e332c93ba39821874  guix-build-774323e378ac/output/x86_64-apple-darwin/SHA256SUMS.part
cb64acd4272f9225ee69040d1422a1f53260942d6b63b56245b8f990eb12989f  guix-build-774323e378ac/output/x86_64-apple-darwin/bitcoin-774323e378ac-osx-unsigned.dmg
d5ed3d7951a2cd0c43219d348d9c6925c86073e5ccd3d7b4e8d79db59b22154b  guix-build-774323e378ac/output/x86_64-apple-darwin/bitcoin-774323e378ac-osx-unsigned.tar.gz
37b52e8188a3cef88c66e9e17a9e8dd7cf048e119470c77396d3d1bb26c5b1a3  guix-build-774323e378ac/output/x86_64-apple-darwin/bitcoin-774323e378ac-osx64.tar.gz
ea1f4f3ff3ab9b0d6dc7c307a476d01eb77411e0cec8c2da39a3be6c507e632b  guix-build-774323e378ac/output/x86_64-linux-gnu/SHA256SUMS.part
1036fe95582b8c111f17528c047ed19e8377720d4b7291edafd6cdcb3e59c634  guix-build-774323e378ac/output/x86_64-linux-gnu/bitcoin-774323e378ac-x86_64-linux-gnu-debug.tar.gz
e1fbd135d56dd6855acbe27480ec76c3b4c548f8ae26427b8aa7d197a835c4a7  guix-build-774323e378ac/output/x86_64-linux-gnu/bitcoin-774323e378ac-x86_64-linux-gnu.tar.gz
c13bca92a47a7c04e3f8f3aef2c755bd37db91a134ddb65f6e9f0da4fb8dcd72  guix-build-774323e378ac/output/x86_64-w64-mingw32/SHA256SUMS.part
d2ae028987d096a74c06d496949987e1ef015c7ef54285a09dc98af18ab9a2b1  guix-build-774323e378ac/output/x86_64-w64-mingw32/bitcoin-774323e378ac-win-unsigned.tar.gz
0b56bb298195ef344639d8079d28cf8bd755f911babe1823e5ff3b034486d2b6  guix-build-774323e378ac/output/x86_64-w64-mingw32/bitcoin-774323e378ac-win64-debug.zip
ddc4a904c3a7a4403a7596422a6e4c81ede31ae1ecad3e7291a20eeef7586302  guix-build-774323e378ac/output/x86_64-w64-mingw32/bitcoin-774323e378ac-win64-setup-unsigned.exe
7346baae12f4b11bd0a11267c1e3bcffd3e022ac9f0a80fb6e2e7cb5c09453f9  guix-build-774323e378ac/output/x86_64-w64-mingw32/bitcoin-774323e378ac-win64.zip

@hebasto
Copy link
Member Author

hebasto commented Feb 23, 2022

@MarcoFalke

I wasn't aware this affects guix builds

It does because we use boost 1.71.0 in depends.

It is not the case now as #24383 has just been merged.

@maflcko
Copy link
Member

maflcko commented Feb 23, 2022

Is this for 0.23?

@hebasto
Copy link
Member Author

hebasto commented Feb 23, 2022

Is this for 0.23?

Both this PR and #24415 are bugfixes. So I guess yes, we should strive to get both of them in 0.23.

OTOH, users with system boost <=1.73 or >=1.78 always have an opportunity to build depends.

@maflcko maflcko requested a review from fanquake February 23, 2022 17:59
@DrahtBot
Copy link
Contributor

Guix builds

File commit c44e734
(master)
commit 46f4bf0ce58580d3a11b48538c5db97fb984653e
(master and this pull)
SHA256SUMS.part 7c8db8209ea98402... 8d5cf05203c457df...
*-aarch64-linux-gnu-debug.tar.gz 5cb9dac9fe0211e9... 549ebf3745719bfb...
*-aarch64-linux-gnu.tar.gz 0a13a82c487a5abf... 7f399a5719c17347...
*-arm-linux-gnueabihf-debug.tar.gz f7c63679ccea10ea... b67db104351ca0d1...
*-arm-linux-gnueabihf.tar.gz 26d9522cd9c4a77b... 39563739a4d048d4...
*-arm64-apple-darwin.tar.gz a62210bdfa0e5808... 0a6bfd7280f344da...
*-osx-unsigned.dmg 69e8b352e17fb5d9... 59bf7e8cb4d8812b...
*-osx-unsigned.tar.gz 3d09aae72c689c0e... 60bcd51f2b432973...
*-osx64.tar.gz ee5c5ccd6e72ec05... 8a418a00d6a5b34f...
*-powerpc64-linux-gnu-debug.tar.gz 5c5e2a8badaf96c5... a45631204b56d0c5...
*-powerpc64-linux-gnu.tar.gz 3ce67cbf1664fe57... eb8b6eee0b61d14d...
*-powerpc64le-linux-gnu-debug.tar.gz 3f6924446de7e6f6... 636b66b438987288...
*-powerpc64le-linux-gnu.tar.gz 35e1ee13cab0603a... 6b6e1bc68241ebdb...
*-riscv64-linux-gnu-debug.tar.gz d2e26c52f1b629ee... 63f7398249c5e08a...
*-riscv64-linux-gnu.tar.gz 025631638b565d96... 7f3bbdf425221431...
*-win-unsigned.tar.gz 1c5c1ac4cadd80a7... 2826320f2f34b9ad...
*-win64-debug.zip 3130d886149e9323... 8bca4d0f6a9783ad...
*-win64-setup-unsigned.exe a6b33be0728992d6... 4b1b50d0ac50add7...
*-win64.zip 67d8e8048768c763... 24fa7039fe80f967...
*-x86_64-linux-gnu-debug.tar.gz ecc2a710fd6ae082... 34fd151529e95f9d...
*-x86_64-linux-gnu.tar.gz 042c47ded72206a1... aa6bfdaf7a0db262...
*.tar.gz 1987a873e5bdd7f3... ef3387ade963e6b1...
guix_build.log 1e49d612dcc86d49... 24df598e13f17067...
guix_build.log.diff 48166cf9ffbb9af7...

@fanquake
Copy link
Member

Guix Build:

bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
6d3bc8aea9ba022a0cb7171b9a690a9c5798e838fd7f3c73212c33066cbad3f7  guix-build-774323e378ac/output/aarch64-linux-gnu/SHA256SUMS.part
d35538cf88e4862cd7d48c048d0e78547f5a44b09aa90b2cfa797530c193d854  guix-build-774323e378ac/output/aarch64-linux-gnu/bitcoin-774323e378ac-aarch64-linux-gnu-debug.tar.gz
8887d905d2d690f4f86a40992379db80732cd54cbb01ad142e4945c7ca553690  guix-build-774323e378ac/output/aarch64-linux-gnu/bitcoin-774323e378ac-aarch64-linux-gnu.tar.gz
544271d9bc866b4525bf3b2260605043ac7e9fed43802e490e2ca0219c59d0a9  guix-build-774323e378ac/output/arm-linux-gnueabihf/SHA256SUMS.part
0329772e725275e73235087ca6d0291947f4bb1800bd70653b055829cae01b62  guix-build-774323e378ac/output/arm-linux-gnueabihf/bitcoin-774323e378ac-arm-linux-gnueabihf-debug.tar.gz
28a5fa4c9150095084b02345f745d07e97a2633b68da1dc3eb6f4c280b516787  guix-build-774323e378ac/output/arm-linux-gnueabihf/bitcoin-774323e378ac-arm-linux-gnueabihf.tar.gz
48c425c5a80d18379883d7ba5db910d1031a34430b9bfe31e9ffb595ab6bd6ed  guix-build-774323e378ac/output/arm64-apple-darwin/SHA256SUMS.part
85aee9958c3ca195b3908328c792c8aa46ab3af488923afd0b149f297e05ff93  guix-build-774323e378ac/output/arm64-apple-darwin/bitcoin-774323e378ac-arm64-apple-darwin.tar.gz
fc4c40ade7b00377f64b728f8a19cfc6939a56e6f966d3b99b6c373d9c90ecd4  guix-build-774323e378ac/output/arm64-apple-darwin/bitcoin-774323e378ac-osx-unsigned.dmg
86bb7442b012585c9751c9a937df3d77c1fb2e45e40f9962cd79f55fd0bc2aa5  guix-build-774323e378ac/output/arm64-apple-darwin/bitcoin-774323e378ac-osx-unsigned.tar.gz
f7b04de225580810c9e5f8999f2e854a36b1fbe5d7c464b2fa5339f831f9fe74  guix-build-774323e378ac/output/dist-archive/bitcoin-774323e378ac.tar.gz
1bce7fdb529f35dedb239ed2c6de1f611caeabdad309a49df26feb9b6e76d370  guix-build-774323e378ac/output/powerpc64-linux-gnu/SHA256SUMS.part
f3460faf9724470f7c3c70785c1ef3f5d344f71e4230687beab8148843c7041b  guix-build-774323e378ac/output/powerpc64-linux-gnu/bitcoin-774323e378ac-powerpc64-linux-gnu-debug.tar.gz
26b8b4bf5f160c5b5926d60346842d65d15e26aae60fec7bac17e144e3bb3f2c  guix-build-774323e378ac/output/powerpc64-linux-gnu/bitcoin-774323e378ac-powerpc64-linux-gnu.tar.gz
72ecb72767d46c26b02ddb9a541e7504d6e84137283f229132728179957a7260  guix-build-774323e378ac/output/powerpc64le-linux-gnu/SHA256SUMS.part
68ff1181a88ad9de08e0310c73f81cf3ceed2db7810ab1059eed8acbc20bac4a  guix-build-774323e378ac/output/powerpc64le-linux-gnu/bitcoin-774323e378ac-powerpc64le-linux-gnu-debug.tar.gz
e691a201d071abe1fb7122fffdf8916bd5a2b01475f937bc37d1004cf773c5ef  guix-build-774323e378ac/output/powerpc64le-linux-gnu/bitcoin-774323e378ac-powerpc64le-linux-gnu.tar.gz
8261d6b583d33f36f0e515064c6e1278054e09fa2eb779a89b25dc5f964d5f64  guix-build-774323e378ac/output/riscv64-linux-gnu/SHA256SUMS.part
230981ac50dd56d5914b726364da1bda0766addb5cc16c32c37ea9e3c41cebee  guix-build-774323e378ac/output/riscv64-linux-gnu/bitcoin-774323e378ac-riscv64-linux-gnu-debug.tar.gz
f8c634f97a08f9f359b32328146752fd00621900d14e02ea4da2d9b556e45976  guix-build-774323e378ac/output/riscv64-linux-gnu/bitcoin-774323e378ac-riscv64-linux-gnu.tar.gz
b55cf1d4a77c4f096a08ed042da5602d98e820d3b7c2bb9e332c93ba39821874  guix-build-774323e378ac/output/x86_64-apple-darwin/SHA256SUMS.part
cb64acd4272f9225ee69040d1422a1f53260942d6b63b56245b8f990eb12989f  guix-build-774323e378ac/output/x86_64-apple-darwin/bitcoin-774323e378ac-osx-unsigned.dmg
d5ed3d7951a2cd0c43219d348d9c6925c86073e5ccd3d7b4e8d79db59b22154b  guix-build-774323e378ac/output/x86_64-apple-darwin/bitcoin-774323e378ac-osx-unsigned.tar.gz
37b52e8188a3cef88c66e9e17a9e8dd7cf048e119470c77396d3d1bb26c5b1a3  guix-build-774323e378ac/output/x86_64-apple-darwin/bitcoin-774323e378ac-osx64.tar.gz
ea1f4f3ff3ab9b0d6dc7c307a476d01eb77411e0cec8c2da39a3be6c507e632b  guix-build-774323e378ac/output/x86_64-linux-gnu/SHA256SUMS.part
1036fe95582b8c111f17528c047ed19e8377720d4b7291edafd6cdcb3e59c634  guix-build-774323e378ac/output/x86_64-linux-gnu/bitcoin-774323e378ac-x86_64-linux-gnu-debug.tar.gz
e1fbd135d56dd6855acbe27480ec76c3b4c548f8ae26427b8aa7d197a835c4a7  guix-build-774323e378ac/output/x86_64-linux-gnu/bitcoin-774323e378ac-x86_64-linux-gnu.tar.gz
c13bca92a47a7c04e3f8f3aef2c755bd37db91a134ddb65f6e9f0da4fb8dcd72  guix-build-774323e378ac/output/x86_64-w64-mingw32/SHA256SUMS.part
d2ae028987d096a74c06d496949987e1ef015c7ef54285a09dc98af18ab9a2b1  guix-build-774323e378ac/output/x86_64-w64-mingw32/bitcoin-774323e378ac-win-unsigned.tar.gz
0b56bb298195ef344639d8079d28cf8bd755f911babe1823e5ff3b034486d2b6  guix-build-774323e378ac/output/x86_64-w64-mingw32/bitcoin-774323e378ac-win64-debug.zip
ddc4a904c3a7a4403a7596422a6e4c81ede31ae1ecad3e7291a20eeef7586302  guix-build-774323e378ac/output/x86_64-w64-mingw32/bitcoin-774323e378ac-win64-setup-unsigned.exe
7346baae12f4b11bd0a11267c1e3bcffd3e022ac9f0a80fb6e2e7cb5c09453f9  guix-build-774323e378ac/output/x86_64-w64-mingw32/bitcoin-774323e378ac-win64.zip

@laanwj
Copy link
Member

laanwj commented Feb 28, 2022

Code review ACK 774323e, is a bugfix/workaround, seems fine to merge last minute for 23.0.

LDFLAGS="$TEMP_LDFLAGS"
AC_MSG_RESULT([$have_boost_process])
if test "$have_boost_process" == "yes"; then
if test "$have_boost_process" = "yes"; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@laanwj laanwj merged commit 2529007 into bitcoin:master Feb 28, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 1, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Feb 28, 2023
@hebasto hebasto deleted the 220220-boost branch January 29, 2024 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants