Skip to content

Conversation

@acktsap
Copy link
Contributor

@acktsap acktsap commented Feb 16, 2022

Fix typos.

Copy link
Member

@jonatack jonatack Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess someone really likes the band? anyway, ACK but could you also fix this one while here

$ test/lint/lint-spelling.sh 
src/crypto/sha256_arm_shani.cpp:65: implemenation ==> implementation

Edit: would probably make more sense to prefix the PR with doc: instead of node, wallet:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 9c2bb5a

@acktsap acktsap changed the title node, wallet: Fix 'the the' in comments doc: Fix 'the the' in comments Feb 16, 2022
@acktsap acktsap changed the title doc: Fix 'the the' in comments doc: Fix typos Feb 16, 2022
@jonatack
Copy link
Member

jonatack commented Feb 16, 2022

Can you please squash the commits down to one prefixed by "doc:" (or no prefix).

@acktsap acktsap force-pushed the fix-the-the-comment branch from 9c2bb5a to ba4906f Compare February 16, 2022 18:43
@acktsap
Copy link
Contributor Author

acktsap commented Feb 16, 2022

Squash & force pushed in ba4906f

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ba4906f

Copy link
Contributor

@Zero-1729 Zero-1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crACK ba4906f

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maflcko maflcko merged commit b304b65 into bitcoin:master Feb 17, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants