-
Notifications
You must be signed in to change notification settings - Fork 38.7k
doc: Fix typos #24359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Fix typos #24359
Conversation
src/wallet/test/wallet_tests.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess someone really likes the band? anyway, ACK but could you also fix this one while here
$ test/lint/lint-spelling.sh
src/crypto/sha256_arm_shani.cpp:65: implemenation ==> implementation
Edit: would probably make more sense to prefix the PR with doc: instead of node, wallet:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! 9c2bb5a
|
Can you please squash the commits down to one prefixed by "doc:" (or no prefix). |
9c2bb5a to
ba4906f
Compare
|
Squash & force pushed in ba4906f |
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ba4906f
Zero-1729
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crACK ba4906f
jonatack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the day your life will surely change https://www.youtube.com/watch?v=7ZYgKCbFbWY
ACK ba4906f
Fix typos.