util: Work around libstdc++ create_directories issue #24338

laanwj · 2022-02-14T12:55:37Z

Work around libstdc++ issue [PR101510] with create_directories where the leaf already exists as a symlink. Fixes #24257, introduced by the switch to std::filesystem. It is meant to be more thorough than #24266, which worked around one instance of the problem.

The issue was fixed upstream, but unfortunately we'll have to carry a fix for it for a while.

This introduces a function fs::create_directories which wraps
std::filesystem::create_directories. This allows easiliy reverting the
workaround when it is no longer necessary.

maflcko · 2022-02-14T13:03:52Z

Concept ACK.

Mind applying this diff: #24266 (comment) ?

Otherwise the blocks dir handling differs from the wallet dir handling (and root dir handling).

laanwj · 2022-02-14T13:07:51Z

Mind applying this diff: #24266 (comment) ?

~~Done!~~
Reverted for now (#24338 (comment)).

src/fs.h

laanwj · 2022-02-14T14:03:38Z

I'm really confused by the CI output:

Traceback (most recent call last):
  File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/combine_logs.py", line 201, in <module>
    main()
  File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/combine_logs.py", line 67, in main
    log_events = read_logs(testdir)
  File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/combine_logs.py", line 86, in read_logs
    assert next(glob, None) is None #  more than one debug.log, should never happen
  File "/usr/lib64/python3.6/pathlib.py", line 1100, in glob
    for p in selector.select_from(self):
  File "/usr/lib64/python3.6/pathlib.py", line 508, in _select_from
    for p in self.successor._select_from(path, is_dir, exists, scandir):
  File "/usr/lib64/python3.6/pathlib.py", line 559, in _select_from
    for starting_point in self._iterate_directories(parent_path, is_dir, scandir):
  File "/usr/lib64/python3.6/pathlib.py", line 549, in _iterate_directories
    for p in self._iterate_directories(path, is_dir, scandir):
  File "/usr/lib64/python3.6/pathlib.py", line 549, in _iterate_directories
    for p in self._iterate_directories(path, is_dir, scandir):
  File "/usr/lib64/python3.6/pathlib.py", line 549, in _iterate_directories
    for p in self._iterate_directories(path, is_dir, scandir):
  File "/usr/lib64/python3.6/pathlib.py", line 547, in _iterate_directories
    if entry.is_dir() and not entry.is_symlink():
OSError: [Errno 40] Too many levels of symbolic links: '/tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_\u20bf_🏃_20220214_135218/wallet_multiwallet_169/node0/regtest/walletdir/self_walletdat_symlink/wallet.dat'

This change doesn't actually create any symbolic links, it just tolerates them, neither does it change any Python code, so I don't understand.

jonatack · 2022-02-14T14:28:38Z

I've haven't been following the issue, but the code makes sense, util and dbwrapper unit tests are green for me on Debian with clang 13.0.1, but wallet_multiwallet.py isn't happy.

wallet_multiwallet.py output

2022-02-14T14:25:38.701000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_5_zm4jhi
2022-02-14T14:25:44.906000Z TestFramework (INFO): Do not allow -upgradewallet with multiwallet
2022-02-14T14:25:45.837000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
  File "/home/jon/projects/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/home/jon/projects/bitcoin/bitcoin/test/functional/wallet_multiwallet.py", line 192, in run_test
    os.rename(wallet_dir2, wallet_dir())
OSError: [Errno 39] Directory not empty: '/tmp/bitcoin_func_test_5_zm4jhi/node0/regtest/walletdir' -> '/tmp/bitcoin_func_test_5_zm4jhi/node0/regtest/wallets'
</p></details>

laanwj · 2022-02-14T14:45:38Z

I've reverted @MarcoFalke 's proposed change for now. Let's see if this passes CI.

src/fs.h

maflcko · 2022-02-14T15:14:08Z

I've reverted @MarcoFalke 's proposed change for now. Let's see if this passes CI.

Interesting. For reference, the failed CI is here: https://cirrus-ci.com/build/6366611337641984

It would be good to know why it failed. Otherwise it seems that the same failure that happened on the wallet dir is going to happen on the blocks dir as well, with this patch.

laanwj · 2022-02-14T15:17:36Z

Otherwise it seems that the same failure that happened on the wallet dir is going to happen on the blocks dir as well, with this patch.

This was the first thing I checked (as it's the problem I'd been suffering from), and it worked fine.

Edit: could it be a problem with making multiple directories at once? I mean, this looks if a path exists before making a subdirectory of it:

    if (!fs::exists(path)) {
        fs::create_directories(path / "wallets");
    }

It's not the same as fs::create_directories(path / "wallets");, which will always create a wallets subdirectory, even if the parent path already exists.

jonatack · 2022-02-14T15:17:41Z

01c5aefa032f1f7d28c132481624e2d74aa1d14b solves the wallet_multiwallet.py error in #24338 (comment) for me locally.

maflcko · 2022-02-14T15:46:48Z

Ugh, my bad. 🤦‍♂️

src/test/dbwrapper_tests.cpp

jonatack · 2022-02-14T17:03:27Z

utACK b9dff100ff2e7dfb9f216e98964fe28ef5bac3a9

The disabled function corresponds to the second create_directories of 3 in https://en.cppreference.com/w/cpp/filesystem/create_directory

w0xlt

If the blocks directory is a symlink, as mentioned in #24257 (comment), the error below still occurs.

************************
EXCEPTION: NSt10filesystem7__cxx1116filesystem_errorE       
filesystem error: cannot create directories: Not a directory [/home/.../.bitcoin/signet/blocks]       
bitcoin in AppInit()

maflcko · 2022-02-15T07:37:53Z

Is it possible to write a test for this with https://docs.python.org/3.8/library/os.html#os.symlink ? (Like the multiwallet test)

laanwj · 2022-02-15T09:10:54Z

If the blocks directory is a symlink, as mentioned in #24257 (comment), the error below still occurs.

Strange, it works here on Ubuntu 20.04. The blocks directory is a symlink.

$ stat ~/.bitcoin/blocks
  File: /home/…/.bitcoin/blocks -> /…/bitcoin/blocks

Without this patch I get

************************
EXCEPTION: NSt10filesystem7__cxx1116filesystem_errorE       
filesystem error: cannot create directories: Not a directory [/home/…/.bitcoin/blocks]       
bitcoin in AppInit()

With this patch, it works:

$ src/bitcoind                                                        
2022-02-15T08:59:11Z Bitcoin Core version v22.99.0-b9dff100ff2e (release build)
…

I have checked the same for signet. Both making the signet directory a link, and signet/blocks.

Is it possible to write a test for this with https://docs.python.org/3.8/library/os.html#os.symlink ? (Like the multiwallet test)

Sure. I'll look into it.

vasild

@w0xlt, @laanwj, I don't have a buggy gcc to experiment, but my guess is that if signet is a symlink and inside blocks is an ordinary directory, then is_symlink("signet/blocks") will return false. In this case our condition will be false and we will call the buggy/system create_directories(). It should return false in that case but maybe it throws instead because of the bug?

src/fs.h

w0xlt · 2022-02-15T16:22:11Z

My bad. The symlink was created using a relative path instead of an absolute one.
Tested with absolute path on Ubuntu 20.04 and this patch worked.

vasild · 2022-02-15T16:43:44Z

@w0xlt, so the link was broken, pointing to a nonexistent file/directory?

w0xlt · 2022-02-15T16:54:08Z

Yes, the link was broken. The relative path did not exist in the bitcoind execution context.

laanwj · 2022-02-16T09:14:38Z

Thanks for double-checking @w0xlt.

hebasto · 2022-02-16T09:54:29Z

Concept ACK, reviewing...

hebasto

Approach ACK b9dff100ff2e7dfb9f216e98964fe28ef5bac3a9.

Maybe add a unit test which being applied to the master branch passes on systems that have libstdc++ already being patched?

src/fs.h

vasild

ACK b9dff100ff2e7dfb9f216e98964fe28ef5bac3a9

I managed to reproduce this and played a bit with it. This PR will fix the problem where the last component of the path is a symlink to a directory (instead of just directory).

Assuming buggy system create_directories(), then in some cases our newly introduced create_directories() still deviates from the standard - e.g. if the last component exists but is not a directory, then we would call the system function which will throw, whereas, according to the standard it should just return false. I think this is ok.

laanwj · 2022-02-16T15:04:56Z

Added @hebasto's unit test (and using fully qualified std::filesystem::is_symlink(p) && std::filesystem::is_directory(p)). Thanks!

vasild

ACK d035b64aa0d1b23f34698cc20df65dd613b4adf7

src/test/fs_tests.cpp

laanwj · 2022-02-16T16:48:05Z

New update:

Guard symlink test to not run on Windows.
Add feature_dirsymlinks functional test that tests running with symlinked blocks and chainstate directories (might also want to test individual symlinked block files, but out of scope for this PR).

w0xlt

tACK 67019cd on Ubuntu 20.04

jonatack

Wasn't able to make the tests fail using gcc 8.4 without the fix but am on debian testing and turns out it has libstdc++ patched. Hopefully another reviewer can see them fail without the fix (thanks for adding them).

re-ACK 67019cde228feef8c41e6c685d62a21e85a2cfd9

test/functional/feature_dirsymlinks.py

hebasto

ACK 67019cde228feef8c41e6c685d62a21e85a2cfd9

src/test/fs_tests.cpp

src/fs.h

laanwj · 2022-02-17T08:39:38Z

Haven't been able to make the new unit or functional test fail without the fix commit. With debian testing, tried compiling with an older gcc 8 (Debian 8.4.0-7). Any tips?

Ubuntu 20.04 is still unpatched, seems the best OS to test this on. Haven't tried it on 22.04 yet (edit: just did—also not patched yet). It makes sense for debian testing to be ahead.

It would be kind of funny if by the time we release, all distros have been patched. That said, the tests are useful to keep.

DrahtBot · 2022-02-17T10:00:17Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#24331 (util: Revert back MoveFileExW call for MinGW-w64 by hebasto)
#24169 (build: Add --enable-c++20 option by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Work around libstdc++ issue [PR101510] with create_directories where the leaf already exists as a symlink. Fixes bitcoin#24257, introduced by the switch to `std::filesystem`. It is meant to be more thorough than bitcoin#24266, which only worked around one instance of the problem. The issue was fixed upstream in https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=124eaa50e0a34f5f89572c1aa812c50979da58fc, but unfortunately we'll have to carry a fix for it for a while. This introduces a function `fs::create_directories` which wraps `std::filesystem::create_directories`. This allows easiliy reverting the workaround when it is no longer necessary.

laanwj · 2022-02-17T11:52:36Z

Rebased for #24331 and addressed @jonatack's python comment.

hebasto

re-ACK b223c3c

jonatack · 2022-02-17T13:05:06Z

Ubuntu 20.04 is still unpatched, seems the best OS to test this on. Haven't tried it on 22.04 yet (edit: just did—also not patched yet). It makes sense for debian testing to be ahead.

It would be kind of funny if by the time we release, all distros have been patched. That said, the tests are useful to keep.

👍

re-ACK b223c3c per git range-diff df08250 67019cd b223c3c

Nice touch adding the splat to rename_and_link() to enforce the named args.

fanquake · 2022-02-17T13:08:47Z

Guix build:

bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
075732c9a4af5d0c3cc09bc7bf8c15ef41c62d0984c4556c2756fb1d684ddc11  guix-build-b223c3c21e89/output/aarch64-linux-gnu/SHA256SUMS.part
fd13a2477eb6400aa00200e46df3dd3734e54f19f156807ba8e0fe2d1659dafb  guix-build-b223c3c21e89/output/aarch64-linux-gnu/bitcoin-b223c3c21e89-aarch64-linux-gnu-debug.tar.gz
8c1c6cd750fdf1cc6f3990a1d15a03076fcdb3fef76916359d76b11370f11e73  guix-build-b223c3c21e89/output/aarch64-linux-gnu/bitcoin-b223c3c21e89-aarch64-linux-gnu.tar.gz
0d957e31ab5645703be7fc62d09c1096677c25b395f97bed11ae7bf1b4da0a44  guix-build-b223c3c21e89/output/arm-linux-gnueabihf/SHA256SUMS.part
44fdc0ddfc86eab2a747f4087bbcf79b532b5d7dd5a77b1ef33b49f5c65a95b9  guix-build-b223c3c21e89/output/arm-linux-gnueabihf/bitcoin-b223c3c21e89-arm-linux-gnueabihf-debug.tar.gz
456b5b91302568e59ee8d5329d065efffcbd7fd76a064cd9c67e7f404dc7249d  guix-build-b223c3c21e89/output/arm-linux-gnueabihf/bitcoin-b223c3c21e89-arm-linux-gnueabihf.tar.gz
3a0c3420152e95c88ac67ecf114e88a43af2b82b17cf5778b66645b4273bf995  guix-build-b223c3c21e89/output/arm64-apple-darwin/SHA256SUMS.part
c2f03f7866bdb1455a277dd2c2539facbf0a64ed256ab226e61422dec60098eb  guix-build-b223c3c21e89/output/arm64-apple-darwin/bitcoin-b223c3c21e89-arm64-apple-darwin.tar.gz
a2093272f16783e68a207fe7ece4f7159dea079c29315f72d4a995201542b514  guix-build-b223c3c21e89/output/arm64-apple-darwin/bitcoin-b223c3c21e89-osx-unsigned.dmg
7c98dcd13c45af6e4039a0cde255818552981c5690dedb764b89bc84c9b09d97  guix-build-b223c3c21e89/output/arm64-apple-darwin/bitcoin-b223c3c21e89-osx-unsigned.tar.gz
c5e1be7e7fd68fc9b0cc87829c94c12dd00386905961b012f778cd1a2eaca1bc  guix-build-b223c3c21e89/output/dist-archive/bitcoin-b223c3c21e89.tar.gz
b6044165141e6dbbf8a2deac093b46bc7216a8f8027a41d551eb6adeb6b35caa  guix-build-b223c3c21e89/output/powerpc64-linux-gnu/SHA256SUMS.part
db025c0407b73aa6ba385d508d3cb9fc5483271fa92bc0cc09065f10230c5d3d  guix-build-b223c3c21e89/output/powerpc64-linux-gnu/bitcoin-b223c3c21e89-powerpc64-linux-gnu-debug.tar.gz
ca4285de33997bd7e6cd3a9ce41038221c488d86c6dcd082c2479d8c18cd0c09  guix-build-b223c3c21e89/output/powerpc64-linux-gnu/bitcoin-b223c3c21e89-powerpc64-linux-gnu.tar.gz
e12d1e7864f79a37639156751b3b03c4e2f9bf9ca53ac9ae279aeabaa1f692ba  guix-build-b223c3c21e89/output/powerpc64le-linux-gnu/SHA256SUMS.part
94b7da0b74207974acb5a3d614397c04acb56a07ae1a97d6e782760ff24271e2  guix-build-b223c3c21e89/output/powerpc64le-linux-gnu/bitcoin-b223c3c21e89-powerpc64le-linux-gnu-debug.tar.gz
7e64a5d5a7f586244684a4c7b275640fb09b82b9591c48b0440b7e5ca16b9781  guix-build-b223c3c21e89/output/powerpc64le-linux-gnu/bitcoin-b223c3c21e89-powerpc64le-linux-gnu.tar.gz
38277de2c4cc5c539796a92e4c97f4dec4eb8a39aee32af97a21fca02e0a3fa7  guix-build-b223c3c21e89/output/riscv64-linux-gnu/SHA256SUMS.part
d89076a6d7c7d693aea0a3ca2ac49e76f2c72ae61261ba1623b34b2d03f4937f  guix-build-b223c3c21e89/output/riscv64-linux-gnu/bitcoin-b223c3c21e89-riscv64-linux-gnu-debug.tar.gz
57741dadfbe3c8b744e3e700a1b8c314d442d99ef3aff281efe4428e5938e8f0  guix-build-b223c3c21e89/output/riscv64-linux-gnu/bitcoin-b223c3c21e89-riscv64-linux-gnu.tar.gz
762aa6260628afbaf5cee1b60a4fcecc7de5453b1b526bbba222c85b33e1ac7f  guix-build-b223c3c21e89/output/x86_64-apple-darwin/SHA256SUMS.part
21a5d675de49c2cc2c94406e1d5b5565c0c04d8c7f21b7d8fde111dd68ffcb9f  guix-build-b223c3c21e89/output/x86_64-apple-darwin/bitcoin-b223c3c21e89-osx-unsigned.dmg
1caf7a2115fc0aac3216cd06cdb4eb3c715299f6e707eb6ebe0cd62acffa2621  guix-build-b223c3c21e89/output/x86_64-apple-darwin/bitcoin-b223c3c21e89-osx-unsigned.tar.gz
81b0cc3cbc308ebc6b778fdfc2f38c550e273883c47f909d12b7e096d3d950ca  guix-build-b223c3c21e89/output/x86_64-apple-darwin/bitcoin-b223c3c21e89-osx64.tar.gz
0a3b41c634a9952c0084fd43f757971e9b55dd099b850b4585621be263ed01cf  guix-build-b223c3c21e89/output/x86_64-linux-gnu/SHA256SUMS.part
c0d461b1006201f2ae202019f06cb4709a2627f0e28a8cd9ebafed6ee8bd8231  guix-build-b223c3c21e89/output/x86_64-linux-gnu/bitcoin-b223c3c21e89-x86_64-linux-gnu-debug.tar.gz
31bcf08af8012bfbff3e417c784ee0d546f916d24495143cff581a23e0bb9690  guix-build-b223c3c21e89/output/x86_64-linux-gnu/bitcoin-b223c3c21e89-x86_64-linux-gnu.tar.gz
c9bb21542cdb876ef9e7dd4b4d18dda2955d56a003b5e06ff171f8480d52bb15  guix-build-b223c3c21e89/output/x86_64-w64-mingw32/SHA256SUMS.part
ccf12d1929669f1edbe80496e7cd48b96eb336de596c46b666802c784aec9808  guix-build-b223c3c21e89/output/x86_64-w64-mingw32/bitcoin-b223c3c21e89-win-unsigned.tar.gz
4f91e09b2ba0b130e101ce3e8616463d8f4a72098c9adc1ac46fa7aa5bf92188  guix-build-b223c3c21e89/output/x86_64-w64-mingw32/bitcoin-b223c3c21e89-win64-debug.zip
6d40204e81732857cf28a32262e9ae4170714627efc81ebe7ddad7b50faa45b1  guix-build-b223c3c21e89/output/x86_64-w64-mingw32/bitcoin-b223c3c21e89-win64-setup-unsigned.exe
9c6881f8734ffa8b0765aa791b10c28e8ce0f983ca35b3ba2ddf2577173cdd58  guix-build-b223c3c21e89/output/x86_64-w64-mingw32/bitcoin-b223c3c21e89-win64.zip

w0xlt

re-ACK b223c3c

vasild

ACK b223c3c

test/functional/feature_dirsymlinks.py

…ssue b223c3c test: Add functional test for symlinked blocks directory (laanwj) ddb75c2 test: Add fs_tests/create_directories unit test (Hennadii Stepanov) 1f46b6e util: Work around libstdc++ create_directories issue (laanwj) Pull request description: Work around libstdc++ issue [PR101510] with create_directories where the leaf already exists as a symlink. Fixes bitcoin#24257, introduced by the switch to `std::filesystem`. It is meant to be more thorough than bitcoin#24266, which worked around one instance of the problem. The issue was [fixed upstream](https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=124eaa50e0a34f5f89572c1aa812c50979da58fc), but unfortunately we'll have to carry a fix for it for a while. This introduces a function `fs::create_directories` which wraps `std::filesystem::create_directories`. This allows easiliy reverting the workaround when it is no longer necessary. ACKs for top commit: jonatack: re-ACK b223c3c per `git range-diff df08250 67019cd b223c3c` hebasto: re-ACK b223c3c w0xlt: re-ACK b223c3c vasild: ACK b223c3c Tree-SHA512: 028321717c8b10d16185c3711b35da6b05fb7aa31cee1c8c7e754e92bf5a0b02719a3785cd0f6f8bf052b3bd759f644af212320672baabc9e44e0b93ba464abc

laanwj added the Utils/log/libs label Feb 14, 2022

laanwj added this to the 23.0 milestone Feb 14, 2022

laanwj force-pushed the 2022-02-create-directories branch from 36a6815 to e6fafbd Compare February 14, 2022 13:07

jonatack reviewed Feb 14, 2022

View reviewed changes

src/fs.h Outdated Show resolved Hide resolved

laanwj force-pushed the 2022-02-create-directories branch from e6fafbd to 01c5aef Compare February 14, 2022 14:45

vasild reviewed Feb 14, 2022

View reviewed changes

src/fs.h Outdated Show resolved Hide resolved

src/fs.h Outdated Show resolved Hide resolved

maflcko reviewed Feb 14, 2022

View reviewed changes

src/test/dbwrapper_tests.cpp Outdated Show resolved Hide resolved

laanwj force-pushed the 2022-02-create-directories branch from 01c5aef to b9dff10 Compare February 14, 2022 16:15

w0xlt reviewed Feb 15, 2022

View reviewed changes

vasild reviewed Feb 15, 2022

View reviewed changes

src/fs.h Outdated Show resolved Hide resolved

hebasto reviewed Feb 16, 2022

View reviewed changes

src/fs.h Outdated Show resolved Hide resolved

ghost mentioned this pull request Feb 16, 2022

bitcoind and bitcoin-cli does not supports symbolic link anymore #24257

Closed

vasild approved these changes Feb 16, 2022

View reviewed changes

laanwj force-pushed the 2022-02-create-directories branch from b9dff10 to d035b64 Compare February 16, 2022 15:13

vasild approved these changes Feb 16, 2022

View reviewed changes

laanwj commented Feb 16, 2022

View reviewed changes

src/test/fs_tests.cpp Outdated Show resolved Hide resolved

laanwj force-pushed the 2022-02-create-directories branch from d035b64 to 67019cd Compare February 16, 2022 16:46

w0xlt approved these changes Feb 16, 2022

View reviewed changes

jonatack reviewed Feb 16, 2022

View reviewed changes

test/functional/feature_dirsymlinks.py Outdated Show resolved Hide resolved

hebasto approved these changes Feb 16, 2022

View reviewed changes

src/test/fs_tests.cpp Outdated Show resolved Hide resolved

src/fs.h Outdated Show resolved Hide resolved

DrahtBot mentioned this pull request Feb 17, 2022

util: Revert back MoveFileExW call for MinGW-w64 #24331

Merged

laanwj and others added 3 commits February 17, 2022 12:30

test: Add fs_tests/create_directories unit test

ddb75c2

test: Add functional test for symlinked blocks directory

b223c3c

DrahtBot added the Needs rebase label Feb 17, 2022

laanwj force-pushed the 2022-02-create-directories branch from 67019cd to b223c3c Compare February 17, 2022 11:51

hebasto approved these changes Feb 17, 2022

View reviewed changes

DrahtBot removed the Needs rebase label Feb 17, 2022

w0xlt approved these changes Feb 17, 2022

View reviewed changes

vasild approved these changes Feb 17, 2022

View reviewed changes

test/functional/feature_dirsymlinks.py Show resolved Hide resolved

DrahtBot mentioned this pull request Feb 17, 2022

build: Add --enable-c++20 option #24169

Merged

fanquake merged commit 003523d into bitcoin:master Feb 17, 2022

bitcoin locked and limited conversation to collaborators Feb 18, 2023

util: Work around libstdc++ create_directories issue #24338

util: Work around libstdc++ create_directories issue #24338

Uh oh!

Conversation

laanwj commented Feb 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Feb 14, 2022

Uh oh!

laanwj commented Feb 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

laanwj commented Feb 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonatack commented Feb 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Feb 14, 2022

Uh oh!

Uh oh!

Uh oh!

maflcko commented Feb 14, 2022

Uh oh!

laanwj commented Feb 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonatack commented Feb 14, 2022

Uh oh!

maflcko commented Feb 14, 2022

Uh oh!

Uh oh!

jonatack commented Feb 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w0xlt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maflcko commented Feb 15, 2022

Uh oh!

laanwj commented Feb 15, 2022

Uh oh!

vasild left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

w0xlt commented Feb 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vasild commented Feb 15, 2022

Uh oh!

w0xlt commented Feb 15, 2022

Uh oh!

laanwj commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Feb 16, 2022

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vasild left a comment

Choose a reason for hiding this comment

Uh oh!

laanwj commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vasild left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

laanwj commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w0xlt left a comment

Choose a reason for hiding this comment

laanwj commented Feb 14, 2022 •

edited

Loading

laanwj commented Feb 14, 2022 •

edited

Loading

laanwj commented Feb 14, 2022 •

edited

Loading

jonatack commented Feb 14, 2022 •

edited

Loading

laanwj commented Feb 14, 2022 •

edited

Loading

jonatack commented Feb 14, 2022 •

edited

Loading

w0xlt left a comment •

edited

Loading

vasild left a comment •

edited

Loading

w0xlt commented Feb 15, 2022 •

edited

Loading

laanwj commented Feb 16, 2022 •

edited

Loading

laanwj commented Feb 16, 2022 •

edited

Loading

laanwj commented Feb 16, 2022 •

edited

Loading

jonatack left a comment •

edited

Loading

laanwj commented Feb 17, 2022 •

edited

Loading