tests: commit-script-check.sh - use gsed if exists #24159
Conversation
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
Approach ACK 0b4f7a90ece39e6c88f746673de3764fb147779e
This PR introduces a check for the sed type in the commit-script-check.sh. The selected version of SED (whether gsed or sed) is then passed through the inspection if the sed is 'GNU' based.
I think it would be good incorporating @brunoerg's suggestion.
|
merged @brunoerg commit - will squash after CI pass. |
On macOS the default sed utility is not GNU sed, therefore the commit-script-check.sh script fails. This commit adds a check for gsed and uses it if it exists. Co-authored-by: Bruno Garcia <[email protected]>
RandyMcMillan
force-pushed
the
1643135199-test-lint-comit-script
branch
from
c56df55 to
ca3d686
Compare
|
Concept ACK |
|
I know I'm repeating myself but I really prefer more complex scripts to be Python to avoid these kind of platform-specific contortions around different shells and basic utilities. Lacking that, Concept ACK. |
|
Going to optimistically close this for now, given we are just going to port this to Python (#24783). I'm sure we can come up with a solution that doesn't require sed, or gsed or bash, or any other nonsense. |
8 participants
On macOS the default sed utility is not GNU sed,
therefore the commit-script-check.sh script fails.
This commit adds a check for gsed and uses it if it exists.