Skip to content

doc: Update the used Qt version #24130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 1 commit into from
Jan 25, 2022
Merged

doc: Update the used Qt version #24130

fanquake merged 1 commit into from
Jan 25, 2022

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Jan 23, 2022

Missed in #23489.

w0xlt
w0xlt approved these changes Jan 23, 2022
View reviewed changes
Copy link
Contributor

@w0xlt w0xlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d67fc78

shaavan
shaavan approved these changes Jan 23, 2022
View reviewed changes
Copy link
Contributor

@shaavan shaavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d67fc78

A minor but crucial change.

  • Verified that the version by our codebase has been bumped up from 5.12.11 -> 5.15.2 in #23489.
  • This change was not reflected in depend docs until now, which this PR fixes.

@DrahtBot DrahtBot added the Docs label Jan 23, 2022
prusnak
prusnak approved these changes Jan 23, 2022
View reviewed changes
Copy link
Contributor

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d67fc78

@DrahtBot DrahtBot mentioned this pull request Jan 23, 2022
Merged
@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 23, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #24132 (build: Bump minimum Qt version to 5.11.3 by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

promag
promag reviewed Jan 23, 2022
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d67fc78.

@maflcko maflcko requested a review from fanquake January 24, 2022 11:45
@fanquake fanquake merged commit 69ef0a1 into bitcoin:master Jan 25, 2022
@hebasto hebasto deleted the 220123-deps branch January 25, 2022 12:47
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 28, 2022
@fanquake
Merge bitcoin#24130: doc: Update the used Qt version
da24024 
d67fc78 doc: Update the used Qt version (Hennadii Stepanov)

Pull request description:

  Missed in bitcoin#23489.

ACKs for top commit:
  w0xlt:
    ACK d67fc78
  shaavan:
    ACK d67fc78
  prusnak:
    ACK d67fc78
  promag:
    ACK d67fc78.

Tree-SHA512: f15d83dca1c7dcdb9bd862358cd0e9a2740d88b8eaa0de8223210c9ce89e7526c6f98908bf26d512ff9271d6d59fda1d0c7ac97fcd7ef4b8b0c06d24b9d62f33
@bitcoin bitcoin locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fanquake fanquake Awaiting requested review from fanquake

4 more reviewers

@promag promag promag left review comments

@prusnak prusnak prusnak approved these changes

@shaavan shaavan shaavan approved these changes

@w0xlt w0xlt w0xlt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hebasto @DrahtBot @prusnak @promag @shaavan @w0xlt @fanquake