net, refactor: Rename CNetMessage::m_command with CNetMessage::m_type #24078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-BEGIN VERIFY SCRIPT- sed -i 's/std::string m_command;/std::string m_type;/g' ./src/net.h sed -i 's/* command and size./* type and size./g' ./src/net.h sed -i 's/msg.m_command/msg.m_type/g' ./src/net.cpp ./src/net_processing.cpp ./src/test/fuzz/p2p_transport_serialization.cpp -END VERIFY SCRIPT-
theStack
approved these changes
Jan 16, 2022
Contributor
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
Concept and code-review ACK 224d878
There are still quite a few instances of the confusing "command" terminology for message types around, as $ git grep -i command ./src/net* shows. Happy to review further changes in this direction (either in this PR or a follow-up).
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jan 16, 2022
shaavan
approved these changes
Jan 20, 2022
Contributor
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
Code Review ACK 224d878
Going commit wise:
- I agree with this statement, and hence with the change:
a message is not a command, but simply a message of some type
- Removing these redundant variables makes the code more clean and readable.
w0xlt
approved these changes
Jan 23, 2022
maflcko
reviewed
Jan 24, 2022
| // decompose a single CNetMessage from the TransportDeserializer | ||
| CNetMessage msg(std::move(vRecv)); | ||
|
|
||
| // store command string, time, and sizes |
Member
There was a problem hiding this comment.
I think there are a few comments which could be updated.
git grep --ignore-case command ./src/net*
Contributor
There was a problem hiding this comment.
Let me take it up as a follow-up.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 28, 2022
…h CNetMessage::m_type 224d878 net, refactor: Drop tautological local variables (Hennadii Stepanov) 3073a99 scripted-diff: Rename CNetMessage::m_command with CNetMessage::m_type (Hennadii Stepanov) Pull request description: bitcoin#18533 (comment): > a message is not a command, but simply a message of some type Continuation of bitcoin#18533 and bitcoin#18937. ACKs for top commit: theStack: Concept and code-review ACK 224d878 shaavan: Code Review ACK 224d878 w0xlt: crACK 224d878 Tree-SHA512: 898cafb44708dae1413fcc1533d809d75878891354f1b5edaaec1287f4921c31adc9330f4d42d82544a39689886bc17fee71ea587f9199fd5cc849d376f82176
maflcko
pushed a commit
that referenced
this pull request
May 5, 2022
…c/net.cpp e71c51b refactor: rename command -> message type in comments in the src/net* files (Shashwat) 2b09593 scripted-diff: Rename message command to message type (Shashwat) Pull request description: This PR is a follow-up to #24078. > a message is not a command, but simply a message of some type The first commit covers the message_command variable name and comments not addressed in the original PR in `src/net*` files. The second commit goes beyond the original `src/net*` limit of #24078 and does similar changes in the `src/rpc/net.cpp` file. ACKs for top commit: MarcoFalke: review ACK e71c51b 💥 Tree-SHA512: 24015d132c00f15239e5d3dc7aedae904ae3103a90920bb09e984ff57723402763f697d886322f78e42a0cb46808cb6bc9d4905561dc6ddee9961168f8324b05
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 5, 2022
… src/rpc/net.cpp e71c51b refactor: rename command -> message type in comments in the src/net* files (Shashwat) 2b09593 scripted-diff: Rename message command to message type (Shashwat) Pull request description: This PR is a follow-up to bitcoin#24078. > a message is not a command, but simply a message of some type The first commit covers the message_command variable name and comments not addressed in the original PR in `src/net*` files. The second commit goes beyond the original `src/net*` limit of bitcoin#24078 and does similar changes in the `src/rpc/net.cpp` file. ACKs for top commit: MarcoFalke: review ACK e71c51b 💥 Tree-SHA512: 24015d132c00f15239e5d3dc7aedae904ae3103a90920bb09e984ff57723402763f697d886322f78e42a0cb46808cb6bc9d4905561dc6ddee9961168f8324b05
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18533 (comment):
Continuation of #18533 and #18937.