refactor: add thread safety lock assertion to WriteBlockIndexDB() #24002
Conversation
The new helper function, BlockManager::WriteBlockIndexDB(), has a thread safety lock annotation in its declaration but is missing the corresponding run-time lock assertion in its definition. Per doc/developer-notes.md: "Combine annotations in function declarations with run-time asserts in function definitions."
|
Combine into #22932 once it's rebased? |
This code doesn't touch that pull. (It's also been open for several months without ACKs, so I'm planning to split it up into smaller pulls to ease review.) |
That would be difficult given the code modified here has only been added to the repo since that PR was last rebased. I suggested combining because #22932 is full of changes very similar to this one. |
|
#22932 does not touch this function and there is no guarantee that it will be merged. I plan to reduce its scope or perhaps close it. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
cr ACK 1823766 |
jonatack
deleted the
add-thread-safety-lock-assertion-to-WriteBlockIndexDB
branch
…iteBlockIndexDB() 1823766 refactor: add thread safety lock assertion to WriteBlockIndexDB() (Jon Atack) Pull request description: New helper function `BlockManager::WriteBlockIndexDB()` added in bitcoin#23974 has a thread safety lock annotation in its declaration but is missing the corresponding run-time lock assertion in its definition. Per doc/developer-notes.md: "Combine annotations in function declarations with run-time asserts in function definitions." ACKs for top commit: MarcoFalke: cr ACK 1823766 Tree-SHA512: b915e6b105c38b8bbe04ad810aefa68e940a13b8dd265e79563a2aaefc93ffa031d56a7f3c481a5ada90de7c2ddd3b419dcfa46c22fa26c22f95eda15cd243bc
4 participants
New helper function
BlockManager::WriteBlockIndexDB()added in #23974 has a thread safety lock annotation in its declaration but is missing the corresponding run-time lock assertion in its definition.Per doc/developer-notes.md: "Combine annotations in function declarations with run-time asserts in function definitions."