Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Jan 3, 2022

This is a prerequisite for #23955. It updates zeromq to the latest available version, and adds a patch, that I've sent upstream, to fix building on NetBSD Current (10).

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 3, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 5, 2022

Guix builds

File commit 75a227e
(master)
commit 0a00ac040a86e3a3d3e3f48d71c4192656394361
(master and this pull)
SHA256SUMS.part dd4b63f7000e9a2b... 80dc1dba92d7840c...
*-aarch64-linux-gnu-debug.tar.gz f81f02e8e5e297a6... e640b196332d7a98...
*-aarch64-linux-gnu.tar.gz 8a2e48f77a9b0933... c1b1e3f2de2c12b1...
*-arm-linux-gnueabihf-debug.tar.gz b1f639ae7e1dd615... a229c32a878f73cc...
*-arm-linux-gnueabihf.tar.gz 5a287ec18bd024a3... f78c5d3becfdd22f...
*-osx-unsigned.dmg 9c3d6937db5f9e78... af10ef31be0b5838...
*-osx-unsigned.tar.gz 4c2468061d558b0a... f82bc4cc347bdc2b...
*-osx64.tar.gz c14c307cd9a0e8ac... 1c01d01df05dd327...
*-powerpc64-linux-gnu-debug.tar.gz 88222558bb0510b1... 0fef192c7aefefa1...
*-powerpc64-linux-gnu.tar.gz 480123cafb973185... be46e83bec611230...
*-powerpc64le-linux-gnu-debug.tar.gz 444f9bc763037f89... 391f6266fafc38db...
*-powerpc64le-linux-gnu.tar.gz 3a3cc32943ed9395... 3b62b728ad7e866f...
*-riscv64-linux-gnu-debug.tar.gz 3a1284fc598ede53... 76ca1f3137bc4e08...
*-riscv64-linux-gnu.tar.gz a57a7900e61d9485... 87a78550228f1664...
*-win-unsigned.tar.gz 2eea095a12f1379c... 755b28b97b5f05bb...
*-win64-debug.zip 5979762ed6ec3c24... 82235e304198e950...
*-win64-setup-unsigned.exe 54fc4abdb513094d... 9d322c752874f582...
*-win64.zip 73b6eca41b769407... c42fd92a73a01f0c...
*-x86_64-linux-gnu-debug.tar.gz fa725a1a137736da... 5fe4c6c279dbb6b8...
*-x86_64-linux-gnu.tar.gz 32885c1f6a9d26ff... fb11c220188a4cde...
*.tar.gz a1ea01f97f5a2cd7... a170eb201d308d6d...
guix_build.log e9e5a16c8901d609... eedefdb6b989c1bf...
guix_build.log.diff d58927b3bc046283...

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6897c4b, I have reviewed the code and it looks OK, I agree it can be merged.

Did not build on NetBSD though.

@fanquake fanquake merged commit 7102f7d into bitcoin:master Jan 20, 2022
@fanquake fanquake deleted the zeromq_4_3_4 branch January 20, 2022 01:37
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 20, 2022
…10 build

6897c4b build: patch depends zeromq to fix building on NetBSD Current (fanquake)
ce6dd2f zeromq 4.3.4 (fanquake)

Pull request description:

  This is a prerequisite for bitcoin#23955. It updates zeromq to the latest available version, and adds a patch, [that I've sent upstream](zeromq/libzmq#4326), to fix building on NetBSD Current (10).

ACKs for top commit:
  hebasto:
    ACK 6897c4b, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: d05d9753630faebe842e1ca70c8c4af660a38e7331a9d95e84df3a3b14564c5118ca41c4fc49fb71dfee563b63e1014e5a3f8874d652e26de59e8e188a12970e
@bitcoin bitcoin locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants