-
Notifications
You must be signed in to change notification settings - Fork 38.8k
build: use zeromq 4.3.4 in depends & fix NetBSD 10 build #23956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
This was referenced Jan 3, 2022
Contributor
hebasto
approved these changes
Jan 12, 2022
Member
hebasto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 6897c4b, I have reviewed the code and it looks OK, I agree it can be merged.
Did not build on NetBSD though.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 20, 2022
…10 build 6897c4b build: patch depends zeromq to fix building on NetBSD Current (fanquake) ce6dd2f zeromq 4.3.4 (fanquake) Pull request description: This is a prerequisite for bitcoin#23955. It updates zeromq to the latest available version, and adds a patch, [that I've sent upstream](zeromq/libzmq#4326), to fix building on NetBSD Current (10). ACKs for top commit: hebasto: ACK 6897c4b, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: d05d9753630faebe842e1ca70c8c4af660a38e7331a9d95e84df3a3b14564c5118ca41c4fc49fb71dfee563b63e1014e5a3f8874d652e26de59e8e188a12970e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for #23955. It updates zeromq to the latest available version, and adds a patch, that I've sent upstream, to fix building on NetBSD Current (10).