Skip to content

Conversation

@theStack
Copy link
Contributor

@theStack theStack commented Jan 1, 2022

@fanquake fanquake added the Docs label Jan 1, 2022
Copy link
Contributor

@shaavan shaavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2e42050

This indeed seems like a typo.

Other places in the codebase where documentation mentions rev????.dat are store undo files.

Screenshot from 2022-01-01 19-25-53

I am also adding the screenshot of the conversation discussed in the PR description.

Screenshot from 2022-01-01 19-23-10

@fanquake fanquake merged commit e9ee023 into bitcoin:master Jan 2, 2022
@0xB10C
Copy link
Contributor

0xB10C commented Jan 2, 2022

Post merge ACK. Thanks for picking this up @theStack!

@theStack theStack deleted the doc-fix_undo_data_filename_comment branch January 2, 2022 01:27
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 2, 2022
…?.dat/)

2e42050 doc: fix undo data filename (s/undo???.dat/rev???.dat/) (Sebastian Falbesoner)

Pull request description:

  This typo was discovered in the course of a review club to bitcoin#20827, see https://bitcoincore.reviews/20827#l-31.

ACKs for top commit:
  shaavan:
    ACK 2e42050

Tree-SHA512: 0c7a00dce24c03bee6d37265d5b4bc97e976c3f3910af1113f967f6298940f892d6fb517f7b154f32ccedb365060314d4d78d5eb2a9c68b25f0859a628209cd3
@bitcoin bitcoin locked and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants