Skip to content

Conversation

@dscotese
Copy link
Contributor

I propose this change so that Windows users can more easily import signers' keys.

To fetch keys of builders and active developers, feed the list of fingerprints
of the primary keys into gpg:

using \*NIX:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it's more usual to say "on UNIX" and "on Windows", instead of "using"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted and applied.

@laanwj laanwj changed the title Added key import code for use with Windows. doc: Add gpg key import instructions for Windows Apr 6, 2022
dscotese and others added 2 commits April 6, 2022 08:07
OS designations slightly more understandable.
@fanquake
Copy link
Member

fanquake commented Apr 6, 2022

You'll need to squash this to a single commit.

@dscotese
Copy link
Contributor Author

dscotese commented Apr 6, 2022

You'll need to squash this to a single commit.

That is not possible on the website, is it?

@fanquake
Copy link
Member

fanquake commented Apr 6, 2022

That is not possible on the website, is it?

No idea, maybe check the documentation: https://docs.github.com/en.

When you're done the commit message should be doc: Add gpg key import instructions for Windows.

@dscotese
Copy link
Contributor Author

dscotese commented Apr 6, 2022

I will make a new pull request with a single commit. The only loss (though I suppose it's recorded here) is that I don't think @fanquake 's help will be attributed.

@dscotese
Copy link
Contributor Author

dscotese commented Apr 6, 2022

New PR is #24788

@dscotese dscotese deleted the patch-1 branch April 6, 2022 19:27
@bitcoin bitcoin locked and limited conversation to collaborators Apr 7, 2022
@laanwj
Copy link
Member

laanwj commented Apr 7, 2022

I wish github did either of two things:

  • Add squashing/rebasing/editing commit titles to the website.
  • Add an option to disable editing through the website. It doesn't have the features needed to take part in the development process here, always creates frustration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants