rest: Expose block filters follow-ups #23836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Dec 22, 2021
Member
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
Concept ACK. For reference, I've also opened #23599 to clean up the RPCTxSerializationFlags function.
I think the pull title and description can be modified to be self-contained. That is, following links is not needed to understand the changes.
dergoegge
force-pushed
the
17631_style_followup
branch
from
c67f1d7 to
4523d28
Compare
Member
Contributor
|
ACK 4523d28 Thanks for picking this up! |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 2, 2022
4523d28 [test] compare filter and header with the result of the getblockfilter RPC (Niklas Gögge) 3a2464f [rest] drop superfluous rpc serializations flags for block filters (Niklas Gögge) 064abd1 [rest] add a more verbose error message for invalid header counts (Niklas Gögge) 83b8f3a [refactor] various style fix-ups (Niklas Gögge) Pull request description: This PR addresses unresolved review comments from [bitcoin#17631](bitcoin#17631). This includes: * various style fix-ups * returning a more verbose error message for invalid header counts * removing superfluous rpc serializations flags for block filters * improving the test to include comparing the block filters returned from the rest with the ones returned from the `getblockfilter` RPC. ACKs for top commit: jnewbery: ACK 4523d28 brunoerg: tACK 4523d28 Tree-SHA512: 634e6b2ae3e1d5f31675a50cfe11a5e74bf5a51b9e7b512d9e18879bf2ed424fc0ac6ec633023f192e3ad12cf0c73b0b51de79dd7ec00844dba3e1493d823b8c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses unresolved review comments from #17631.
This includes:
getblockfilterRPC.