-
Notifications
You must be signed in to change notification settings - Fork 38.6k
test: call VerifyLoadedChainstate during ChainTestingSetup #23736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fanquake
merged 1 commit into
bitcoin:master
from
jamesob:2021-12-verify-loaded-cs-test
Dec 23, 2021
Merged
test: call VerifyLoadedChainstate during ChainTestingSetup #23736
fanquake
merged 1 commit into
bitcoin:master
from
jamesob:2021-12-verify-loaded-cs-test
Dec 23, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Dec 11, 2021
1c6f4e6 to
ad0cf78
Compare
maflcko
reviewed
Dec 13, 2021
Member
maflcko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some q
ad0cf78 to
d99d302
Compare
Contributor
Author
|
@MarcoFalke all fixed, thanks. |
for additional coverage and similarity to actual init process.
d99d302 to
826e12b
Compare
Contributor
Author
|
Should be a pretty easy review... @dongcarl maybe? |
ryanofsky
approved these changes
Dec 20, 2021
Contributor
ryanofsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review ACK 826e12b
Contributor
|
Code Review ACK 826e12b |
Contributor
Author
|
Ready for merge? |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 27, 2021
…stingSetup 826e12b test: call VerifyLoadedChainstate during ChainTestingSetup (James O'Beirne) Pull request description: for additional coverage and similarity to actual init process. Followup to bitcoin#23280. ACKs for top commit: dongcarl: Code Review ACK 826e12b ryanofsky: Code review ACK 826e12b Tree-SHA512: a4e7fd25e5d7a08b1e154ae6daf67c3048260a2684b0e569b544dd826693b7b969db9923b191e499cb8d8d0a2a73eb9330ff45909313145a9abb6052eb8c3ad9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for additional coverage and similarity to actual init process.
Followup to #23280.