Skip to content

Conversation

@jamesob
Copy link
Contributor

@jamesob jamesob commented Dec 10, 2021

for additional coverage and similarity to actual init process.

Followup to #23280.

@DrahtBot DrahtBot added the Tests label Dec 10, 2021
@jamesob jamesob force-pushed the 2021-12-verify-loaded-cs-test branch from 1c6f4e6 to ad0cf78 Compare December 13, 2021 13:21
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some q

@jamesob jamesob force-pushed the 2021-12-verify-loaded-cs-test branch from ad0cf78 to d99d302 Compare December 13, 2021 14:02
@jamesob
Copy link
Contributor Author

jamesob commented Dec 13, 2021

@MarcoFalke all fixed, thanks.

for additional coverage and similarity to actual init process.
@jamesob jamesob force-pushed the 2021-12-verify-loaded-cs-test branch from d99d302 to 826e12b Compare December 13, 2021 14:04
@jamesob
Copy link
Contributor Author

jamesob commented Dec 20, 2021

Should be a pretty easy review... @dongcarl maybe?

Copy link
Contributor

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 826e12b

@dongcarl
Copy link
Contributor

Code Review ACK 826e12b

@jamesob
Copy link
Contributor Author

jamesob commented Dec 22, 2021

Ready for merge?

@fanquake fanquake merged commit f5c678e into bitcoin:master Dec 23, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 27, 2021
…stingSetup

826e12b test: call VerifyLoadedChainstate during ChainTestingSetup (James O'Beirne)

Pull request description:

  for additional coverage and similarity to actual init process.

  Followup to bitcoin#23280.

ACKs for top commit:
  dongcarl:
    Code Review ACK 826e12b
  ryanofsky:
    Code review ACK 826e12b

Tree-SHA512: a4e7fd25e5d7a08b1e154ae6daf67c3048260a2684b0e569b544dd826693b7b969db9923b191e499cb8d8d0a2a73eb9330ff45909313145a9abb6052eb8c3ad9
@bitcoin bitcoin locked and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants