doc: Extract CreateTxDoc in rawtransaction #23639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
review ACK 5bb1f42f492a4e33faebf19e505f67b8581b3001 🙂 Show signatureSignature: |
Member
|
rendered diff: diff --git a/createpsbt b/createpsbt
index a8eac97..4253601 100644
--- a/createpsbt
+++ b/createpsbt
@@ -4,7 +4,7 @@ Creates a transaction in the Partially Signed Transaction format.
Implements the Creator role.
Arguments:
-1. inputs (json array, required) The json objects
+1. inputs (json array, required) The inputs
[
{ (json object)
"txid": "hex", (string, required) The transaction id
diff --git a/createrawtransaction b/createrawtransaction
index cd68d55..787eb2e 100644
--- a/createrawtransaction
+++ b/createrawtransaction
@@ -31,7 +31,7 @@ Arguments:
...
]
3. locktime (numeric, optional, default=0) Raw locktime. Non-0 value also locktime-activates inputs
-4. replaceable (boolean, optional, default=false) Marks this transaction as BIP125-replaceable.
+4. replaceable (boolean, optional, default=false) Marks this transaction as BIP125 replaceable.
Allows this transaction to be replaced by a transaction with higher fees. If provided, it is an error if explicit sequence numbers are incompatible.
Result: |
Member
|
Maybe add the |
For the fields: inputs, outputs, locktime, replaceable
fanquake
force-pushed
the
undup_create_tx_doc
branch
from
5bb1f42 to
c771ee8
Compare
Member
Author
Done. Added to |
Member
|
ACK c771ee8 😸 Show signatureSignature: |
Member
|
rendered diff: diff --git a/createpsbt b/createpsbt
index a8eac97..a1018ca 100644
--- a/createpsbt
+++ b/createpsbt
@@ -4,7 +4,7 @@ Creates a transaction in the Partially Signed Transaction format.
Implements the Creator role.
Arguments:
-1. inputs (json array, required) The json objects
+1. inputs (json array, required) The inputs
[
{ (json object)
"txid": "hex", (string, required) The transaction id
@@ -28,7 +28,7 @@ Arguments:
...
]
3. locktime (numeric, optional, default=0) Raw locktime. Non-0 value also locktime-activates inputs
-4. replaceable (boolean, optional, default=false) Marks this transaction as BIP125 replaceable.
+4. replaceable (boolean, optional, default=false) Marks this transaction as BIP125-replaceable.
Allows this transaction to be replaced by a transaction with higher fees. If provided, it is an error if explicit sequence numbers are incompatible.
Result:
diff --git a/fundrawtransaction b/fundrawtransaction
index 4490741..a93652c 100644
--- a/fundrawtransaction
+++ b/fundrawtransaction
@@ -42,7 +42,7 @@ Arguments:
"unset"
"economical"
"conservative"
- "replaceable": bool, (boolean, optional, default=wallet default) Marks this transaction as BIP125 replaceable.
+ "replaceable": bool, (boolean, optional, default=wallet default) Marks this transaction as BIP125-replaceable.
Allows this transaction to be replaced by a transaction with higher fees
"solving_data": { (json object, optional) Keys and scripts needed for producing a final transaction with a dummy signature.
Used for fee estimation during coin selection.
diff --git a/send b/send
index 28c0ea6..2a59110 100644
--- a/send
+++ b/send
@@ -59,7 +59,7 @@ Arguments:
"unset"
"economical"
"conservative"
- "replaceable": bool, (boolean, optional, default=wallet default) Marks this transaction as BIP125 replaceable.
+ "replaceable": bool, (boolean, optional, default=wallet default) Marks this transaction as BIP125-replaceable.
Allows this transaction to be replaced by a transaction with higher fees
"solving_data": { (json object, optional) Keys and scripts needed for producing a final transaction with a dummy signature.
Used for fee estimation during coin selection.
diff --git a/walletcreatefundedpsbt b/walletcreatefundedpsbt
index 1f3f357..d2a172f 100644
--- a/walletcreatefundedpsbt
+++ b/walletcreatefundedpsbt
@@ -55,7 +55,7 @@ Arguments:
"unset"
"economical"
"conservative"
- "replaceable": bool, (boolean, optional, default=wallet default) Marks this transaction as BIP125 replaceable.
+ "replaceable": bool, (boolean, optional, default=wallet default) Marks this transaction as BIP125-replaceable.
Allows this transaction to be replaced by a transaction with higher fees
"solving_data": { (json object, optional) Keys and scripts needed for producing a final transaction with a dummy signature.
Used for fee estimation during coin selection. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 1, 2021
RandyMcMillan
pushed a commit
to RandyMcMillan/mempool-tab
that referenced
this pull request
Dec 23, 2021
44750a8 doc: use BIP125-replaceable (fanquake) 9c00e9c doc: Extract CreateTxDoc in rawtransaction (fanquake) Pull request description: For the fields: inputs, outputs, locktime, replaceable. Similar to #23172. Can be reviewed with `--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space`. ACKs for top commit: MarcoFalke: ACK 44750a8 😸 Tree-SHA512: e6e4211b89bedec472f8381b3cbea5670f82b728955888c794f694164b8d8bdd51a99c64762b625357ac2171005712b82f81ee7c1b8f5c5620bdedeeefa2b9da
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the fields: inputs, outputs, locktime, replaceable. Similar to #23172.
Can be reviewed with
--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space.