Skip to content

build: don't use deprecated brew package names #23564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 2 commits into from
Nov 22, 2021
Merged

build: don't use deprecated brew package names #23564

fanquake merged 2 commits into from
Nov 22, 2021
+5 −5

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Nov 21, 2021

Fixes:

checking for brew... brew
Warning: Use berkeley-db@4 instead of deprecated berkeley-db4

on macOS.

@hebasto
Copy link
Member

hebasto commented Nov 21, 2021

Concept ACK.

Maybe also s/qt5/qt@5/ a few lines below?

@katesalazar
Copy link
Contributor

katesalazar commented Nov 21, 2021

Concept ACK.

bitcoin/.cirrus.yml

Line 287 in 3688313

- brew install boost libevent berkeley-db4 qt@5 miniupnpc libnatpmp ccache zeromq qrencode sqlite libtool automake pkg-config gnu-getopt

@fanquake
build: don't check for deprecated berkeley-db4 package
d0fe9c2 
Fixes:
```bash
checking for brew... brew
Warning: Use berkeley-db@4 instead of deprecated berkeley-db4
```
@fanquake
build: don't check for deprecated qt5 package
4d83038 
Use qt@5 instead.
@fanquake fanquake force-pushed the dont_use_deprecated_bdb branch from b57813e to 4d83038 Compare November 21, 2021 11:35
@fanquake fanquake changed the title build: don't check for deprecated berkeley-db4 package build: don't use deprecated brew package names Nov 21, 2021
@fanquake
Copy link
Member Author

fanquake commented Nov 21, 2021

Maybe also s/qt5/qt@5/ a few lines below?

Done.

Concept ACK.

bitcoin/.cirrus.yml

Line 287 in 3688313

- brew install boost libevent berkeley-db4 qt@5 miniupnpc libnatpmp ccache zeromq qrencode sqlite libtool automake pkg-config gnu-getopt

Added.

hebasto
hebasto approved these changes Nov 21, 2021
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4d83038, I have reviewed the code and it looks OK, I agree it can be merged.

@katesalazar
Copy link
Contributor

katesalazar commented Nov 21, 2021

Suggest replacing:

build: don't check for deprecated berkeley-db4 package

Fixes:
```bash
checking for brew... brew
Warning: Use berkeley-db@4 instead of deprecated berkeley-db4
```

For:

build: don't check for deprecated berkeley-db4 package

Fixes:

    checking for brew... brew
    Warning: Use berkeley-db@4 instead of deprecated berkeley-db4

Console output is not source code.

@mjdietzx
Copy link
Contributor

mjdietzx commented Nov 21, 2021

Tested ACK 4d83038 on macOS Big Sur

@fanquake fanquake merged commit a2ed33b into bitcoin:master Nov 22, 2021
@fanquake fanquake deleted the dont_use_deprecated_bdb branch November 22, 2021 06:27
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 22, 2021
@fanquake
Merge bitcoin#23564: build: don't use deprecated brew package names
451f96f
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 23, 2021
@fanquake
Merge bitcoin#23564: build: don't use deprecated brew package names
8d45994
@barton2526 barton2526 mentioned this pull request Jan 19, 2022
Merged
@bitcoin bitcoin locked and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hebasto hebasto hebasto approved these changes

Assignees

No one assigned

Labels

Build system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fanquake @hebasto @katesalazar @mjdietzx