doc: Fix typos in endif header comments #23524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
2111-libNode
branch
from
fab9d00 to
fa44237
Compare
Contributor
|
Concept ACK. |
shaavan
approved these changes
Nov 16, 2021
Contributor
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
ACK fa44237
The updated lint-include-guard test makes sure that all three keywords: “ifndef”, “define”, “endif //”, must be present for each header file. This also ensures there are no redundant inundation or whitespaces on the lines in which they are present.
I have tested that the updated test is working correctly in following cases:
- In case extra space is added anywhere on the line (beginning or in the middle)
- Space is removed between “//” and includes guard name.
- “//” is changed.
However, it cannot detect if an extra line is added above or below these keywords.
+
#endif // BITCOIN_LIBSECP256K1_CONFIG_HThough that’s not the case, this test is designed to handle, so it is not an issue.
Member
Author
Correct |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the endif header comments have typos in them (ZMRRPC_H), or are from a different file, or are inconsistently formatted.
Fix all and adjust the linter.