Block uneconomic UTXO creation #2351
Conversation
Based on work by Jeff Garzik
Keeps the UTXO set from being bloated by the creation of outputs that will never be spent because doing so would cost more in fees than they are worth. Includes changes to the UI to ensure the user can't create such outputs, as well as the transaction creation code to round off change if the change txout would itself be unspendable.
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/0df65da397f5b1927783f7a8dba2f69e1cfef3ff for binaries and test log. |
|
Needs unit tests and a thorough test plan. If you want this to be pulled, you'll also need a user-friendly discussion of what this changes and how it affects SatoshiDice, how it affects users who might already have coin dust in their wallets, etc. Or, in other words: writing the code is the easy part... |
|
Oh, frankly I'm surprised you think the issue is settled enough to be writing that stuff at that stage; I wasn't expecting this to be anywhere close to being pulled yet. |
|
If it isn't anywhere close to being pulled, why did you submit it? I don't like "Pull Request As A Forum For Discussion" ... |
|
(oh, WHY I don't like pull-request-as-a-forum-for-discussion: because it make my job harder, and wastes people time reviewing code that may never have a chance of being pulled) |
|
Oh, I see you just want pull-reqs saved for code that has already had the initial discussion about it specifically done elsewhere; the pros and cons of the basic idea and varients have been discussed endlessly elsewhere. |
|
Closing; please re-open when this is ready for pulling into mainline. |
|
Recent data spam seems to make this worth revisiting, and re-opening. |
4 participants
Keeps the UTXO set from being bloated by the creation of outputs that will never be spent because doing so would cost more in fees than they are worth.
Includes changes to the UI to ensure the user can't create such outputs, as well as the transaction creation code to round off change if the change txout would itself be unspendable.