Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Nov 12, 2021

No description provided.

Copy link
Contributor

@mjdietzx mjdietzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept and Approach ACK

@mjdietzx
Copy link
Contributor

Code Review ACK fa186314840a7da165adbfa86a316d8a4c34b706

@maflcko maflcko force-pushed the 2111-fuzzMiniSketch branch from fa18631 to faece21 Compare November 16, 2021 16:40
@maflcko
Copy link
Member Author

maflcko commented Nov 16, 2021

Rebased to fix silent merge conflict. Should be trivial to re-ACK

@maflcko maflcko force-pushed the 2111-fuzzMiniSketch branch from faece21 to fa74d45 Compare November 16, 2021 18:18
@mjdietzx
Copy link
Contributor

re-ACK fa74d45

{
const auto entry{fuzzed_data_provider.ConsumeIntegralInRange<uint32_t>(1, std::numeric_limits<uint32_t>::max() - 1)};
const auto KeepDiff{[&] {
bool& mut{diff[entry]};
Copy link
Member

@sipa sipa Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micronit: diff[entry] ^= true; or diff[entry] ^= 1; also works (feel free to ignore).

@sipa
Copy link
Member

sipa commented Nov 16, 2021

utACK fa74d45

@maflcko maflcko merged commit cb2392c into bitcoin:master Nov 17, 2021
@maflcko maflcko deleted the 2111-fuzzMiniSketch branch November 17, 2021 06:36
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 17, 2021
fa74d45 fuzz: Add minisketch fuzz test (MarcoFalke)

Pull request description:

ACKs for top commit:
  mjdietzx:
    re-ACK fa74d45
  sipa:
    utACK fa74d45

Tree-SHA512: 3d30095c85032139c37c7a2811dd417441a5105cb70af8250000d7b56aeda1e8fab5e65e683fb49d513ef40a81da3967a8a9a70caf40f56cef1dd96c6d4a05f6
@bitcoin bitcoin locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants