build: boring autotools cleanup #23473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Concept ACK, obviously, as I'm using the same style :) Why update Autoconf macros as they have no functional changes? |
Contributor
|
Mostly concept ACK. Checked (only) http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_check_preproc_flag.m4 to see licensing changes come from upstream. |
Member
Author
Mostly just why not, and if we do it now, it saves someone else wanting to do it in the future. I'd think that these files will be very unlikely to be ever updated again after this. |
hebasto
reviewed
Nov 9, 2021
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
Suggesting to add more boring stuff:
AC_CHECK_PROGAC_MSG_WARNAC_MSG_ERRORAC_MSG_RESULT
Why only the first and second arguments are quoted in AC_PATH_PROG(S) and AC_PATH_TOOL?
Contributor
|
Concept ACK, will at least check for binary identity soon. |
Member
Guix builds: |
Contributor
|
GUIX hashes, mine match @hebasto and @fanquake |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
fanquake
force-pushed
the
boring_autotools_cleanup
branch
from
9f0a316 to
d572dd3
Compare
Member
Author
Updated.
Added. |
Member
Guix builds: |
hebasto
approved these changes
Nov 10, 2021
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
ACK d572dd30509406289c591a8c842453113768e943, I verified updated Autoconf macros, I have reviewed the code and it looks OK, I agree it can be merged.
nit: spaces could be added between arguments of the AC_DEFINE_UNQUOTED macro in two places.
This was referenced Nov 10, 2021
Contributor
This was referenced Nov 11, 2021
There should be no functional change.
There should be no functional change.
There should be no functional change.
fanquake
force-pushed
the
boring_autotools_cleanup
branch
from
d572dd3 to
3fa68b3
Compare
hebasto
reviewed
Nov 12, 2021
Member
There was a problem hiding this comment.
After rebasing the following line seems need to be added to the 0ffcb115c062ab69cb82b67a397290e9a1687ccc commit:
Line 488 in c1fb306
fanquake
force-pushed
the
boring_autotools_cleanup
branch
from
3fa68b3 to
34094af
Compare
Member
Author
Done. |
hebasto
approved these changes
Nov 12, 2021
Member
Guix builds: |
Contributor
Guix builds
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly just being consistent with how we do things, and migrating towards a style (we have already been doing so ad-hoc) that is clearer for anyone who cares to read
.m4. For example:master:This PR:
Drop unneeded double-quoting (which we use inconsistently), use
[]for empty arguments, space things out.There should be no functional change, before & after binaries identical. Very boring.
Guix build: