ci: Do not print git log for empty COMMIT_RANGE
#23458
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
That log you link is unfortunate. Concept ACK. |
Member
|
When / why did this start happening; did something change in the Cirrus? |
Member
Author
As for now, the latest Cirrus logs are available for ce09131 (2021-08-10), and CI behavior has not been changed since then. I suspect, it was a flaw in 3c2478c (#20697), which remained unnoticed as no one cares about successful lint task logs :) The issue was spotted while working on #23462. |
Member
|
cr ACK 095f077 |
Member
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 8, 2021
095f077 ci: Do not print `git log` for empty COMMIT_RANGE (Hennadii Stepanov) Pull request description: On master (77a2f5d) a CI lint task [log](https://api.cirrus-ci.com/v1/task/4817858858319872/logs/lint.log) exceeds 20K lines. This PR fixes this issue. ACKs for top commit: MarcoFalke: cr ACK 095f077 Tree-SHA512: 89180018aeccf1599cdf218924cbab12dcbae0f6674bb90e13b64e342cdd908a880b885039c23f0d1d03493e55a94fe04abf39481616ae6550c6a759f5ca9a35
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master (77a2f5d) a CI lint task log exceeds 20K lines.
This PR fixes this issue.