doc: Add note on deleting past-EOL release branches #23323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Oct 20, 2021
Member
|
Concept ACK |
maflcko
force-pushed
the
2110-docRelDel
branch
from
fa14e2c to
fafc44d
Compare
laanwj
reviewed
Oct 20, 2021
maflcko
force-pushed
the
2110-docRelDel
branch
from
fafc44d to
fa68489
Compare
jonatack
reviewed
Oct 20, 2021
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
ACK fa68489ab16a2618d906beff5ecaa598d6faface
maflcko
force-pushed
the
2110-docRelDel
branch
from
fa68489 to
fa38d98
Compare
Member
|
Concept ACK. |
hebasto
reviewed
Oct 20, 2021
| - bitcoincore.org maintained versions update: | ||
| [table](https://github.com/bitcoin-core/bitcoincore.org/commits/master/_includes/posts/maintenance-table.md) | ||
|
|
||
| - Delete post-EOL [release branches](https://github.com/bitcoin/bitcoin/branches/all) and create a tag `v${branch_name}-final`. |
Member
There was a problem hiding this comment.
Shouldn't "delete a branch" and "create a tag" actions be re-ordered?
Member
There was a problem hiding this comment.
Removing the tag is something you do on github, creating the tag is something you do locally (to be able to sign it), so assuming you have the branch locally I don't think there's really a conflict in the order. But yeah.
Member
Author
There was a problem hiding this comment.
Leaving as is for now. Might or might not fix on the next push.
Member
|
Concept ACK |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being done for years now, but wasn't documented.
Some reasons to do it: