lint: enable mypy import checking #23212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanquake
force-pushed
the
22844_fixedup
branch
from
7d82af9 to
26dc789
Compare
Contributor
|
Concept ACK The more high quality automated review we can get prior to manual review the better. |
fanquake
force-pushed
the
22844_fixedup
branch
from
26dc789 to
e71482c
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
This was referenced Oct 7, 2021
fanquake
force-pushed
the
22844_fixedup
branch
from
e71482c to
94a2d8b
Compare
Member
|
Python lints are failing: |
promag
reviewed
Oct 15, 2021
Contributor
There was a problem hiding this comment.
Tested ACK after
diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py
index c5f08b27f2..d6f61bfbff 100755
--- a/test/functional/test_runner.py
+++ b/test/functional/test_runner.py
@@ -40,7 +40,7 @@ except UnicodeDecodeError:
CROSS = "x "
CIRCLE = "o "
-if os.name != 'nt' or sys.getwindowsversion() >= (10, 0, 14393):
+if os.name != 'nt' or sys.getwindowsversion() >= (10, 0, 14393): #type:ignore
if os.name == 'nt':
import ctypes
kernel32 = ctypes.windll.kernel32 # type: ignorebecause getwindowsversion is only available in Windows.
mypy stubs were introduced in 21.0.1
Achieve this by adding some ignore, and making data/ importable. Co-authored-by: João Barbosa <[email protected]>
fanquake
force-pushed
the
22844_fixedup
branch
from
94a2d8b to
a46f71b
Compare
Member
Author
Thanks for the review @promag. Taken the suggestion. |
Contributor
|
ACK |
Contributor
|
cr ACK a46f71b |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 17, 2021
a46f71b lint: enable mypy checking for missing imports (josibake) 22e6526 lint mypy 0.910 (fanquake) 6ae9c2e lint: install pyzmq (22.3.0) into linter environment (josibake) b93e229 doc: remove pointlessly duplicated linter version / install info (fanquake) Pull request description: This is bitcoin#22844 with issues addressed, and two additional commits. One to move to the latest mypy version in the CI, and another to remove what is just pointless duplication from the test README. There's no need to relist package versions and install instructions (meaning 2x the work when changing anything), when you can just link to `04_install.sh` which has the versions used and pip invocations to install them. ACKs for top commit: practicalswift: cr ACK a46f71b Tree-SHA512: 2900dea3901d03a846dc1ea912f217d152e803845516c7d941745ec1291d145590cd4bf2ddc497f7cf628119ba9905d7b1531836062aa85b384e39cf436f62c6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #22844 with issues addressed, and two additional commits. One to move to the latest mypy version in the CI, and another to remove what is just pointless duplication from the test README. There's no need to relist package versions and install instructions (meaning 2x the work when changing anything), when you can just link to
04_install.shwhich has the versions used and pip invocations to install them.