wallet: fund transaction external input cleanups #23188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ACK 7d56d5a77fc7ee9095deb36b8e05f8969461c533 |
Contributor
|
Also please squash, they're all trivial 2 line commits. |
Synchronize error checking for external inputs Rename external output Select to SelectExternal Const FundTransaction variables
instagibbs
force-pushed
the
fundtx-external-inputs_cleanups
branch
from
7d56d5a to
4356878
Compare
Member
Author
|
@meshcollider thanks, I couldn't figure out how many test issues there were in total. Please tag me in the PR for review squashed |
Member
|
ACK 4356878 |
Member
|
Is this "cleanup" a refactoring or a behaviour change? |
Member
Author
|
Should be non behavior changing.
…On Wed, Oct 6, 2021, 4:50 PM MarcoFalke ***@***.***> wrote:
Is this "cleanup" a refactoring or a behaviour change?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23188 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMAFU6UIZT3F4QSE76RKFTUFQEVBANCNFSM5FL2FXZQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanups to #17211