Ensure wallet is unlocked before signing PSBT with walletprocesspsbt and GUI #23106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related GUI issue: bitcoin-core/gui#312 |
promag
reviewed
Sep 27, 2021
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
Concept ACK. Could include a test.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
Author
|
Sure, added a test |
Contributor
Author
|
Added another commit to address the GUI issue @prayank23 mentioned. |
meshcollider
changed the title
Member
|
ACK 7e3ee4c |
|
Post merge tACK 7e3ee4c GUI
CLI |
promag
reviewed
Sep 28, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 28, 2021
…th walletprocesspsbt and GUI 7e3ee4c GUI: Ask user to unlock wallet before signing psbt (Samuel Dobson) 0f3acec Add test that walletprocesspsbt requires unlocked wallet when signing (Samuel Dobson) 0e89521 Ensure wallet is unlocked before signing in walletprocesspsbt (Samuel Dobson) Pull request description: If signing a PSBT, we need to ensure the wallet is unlocked. Fixes bitcoin#22874, fixes bitcoin-core/gui#312 ACKs for top commit: achow101: ACK 7e3ee4c lsilva01: Code Review ACK bitcoin@7e3ee4c benthecarman: ACK 7e3ee4c Tree-SHA512: 6726a873582747900ab454ea21153a92be86808a4c1517dc2856b389876a2da9e8df1ffa9b567b6bd017038342c3544ecf5ca3c97744e7debe0a5ee65563687d
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Oct 10, 2021
Github-Pull: bitcoin#23106 Rebased-From: 0e89521
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Oct 10, 2021
Github-Pull: bitcoin#23106 Rebased-From: 0f3acec
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Oct 10, 2021
Github-Pull: bitcoin#23106 Rebased-From: 7e3ee4c
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 14, 2021
Github-Pull: bitcoin#23106 Rebased-From: 0e89521
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 14, 2021
Github-Pull: bitcoin#23106 Rebased-From: 0f3acec
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 14, 2021
Github-Pull: bitcoin#23106 Rebased-From: 7e3ee4c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If signing a PSBT, we need to ensure the wallet is unlocked.
Fixes #22874, fixes bitcoin-core/gui#312